Bug 237199

Summary: net-im/libpurple: do not always depend on python (2.7)
Product: Ports & Packages Reporter: Pietro Cerutti <gahr>
Component: Individual Port(s)Assignee: Joe Marcus Clarke <marcus>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (marcus)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description Pietro Cerutti freebsd_committer 2019-04-11 11:40:55 UTC
Libpurple needs python only to generate DBUS files, and can do that with 3.6 as well as 2.7.

Please approve the following diff, to depend on python (whatever default version) only when building DBUS. Thanks.

Index: Makefile
===================================================================
--- Makefile    (revision 498663)
+++ Makefile    (working copy)
@@ -3,7 +3,7 @@


 PORTNAME?=     libpurple
 PORTVERSION=   2.13.0
-PORTREVISION=  1
+PORTREVISION=  2
 CATEGORIES?=   net-im
 MASTER_SITES=  SF/pidgin/Pidgin/${PORTVERSION}
 DISTNAME=      pidgin-${PORTVERSION}
@@ -24,7 +24,7 @@
 .if !defined(PIDGIN_SLAVE)
 # Pidgin slave ports that require the following functionality, must explicitly
 # set these macros themselves.
-USES+=         iconv python:2.7 shebangfix
+USES+=         iconv shebangfix
 USE_LDCONFIG=  yes
 SHEBANG_FILES= libpurple/purple-remote \
                libpurple/purple-url-handler
@@ -206,11 +206,12 @@
 .endif


 .if ${PORT_OPTIONS:MDBUS}
+USES+=                 python
 LIB_DEPENDS+=          libdbus-glib-1.so:devel/dbus-glib
 .if !defined(PIDGIN_SLAVE)
 RUN_DEPENDS+=          ${PYTHON_PKGNAMEPREFIX}dbus>=0:devel/py-dbus@${PY_FLAVOR}
 .endif
-CONFIGURE_ARGS+=       --enable-dbus
+CONFIGURE_ARGS+=       --enable-dbus --with-python=${PYTHON_CMD}
 PLIST_SUB+=            DBUS=""
 .else
 CONFIGURE_ARGS+=       --disable-dbus
Comment 1 Joe Marcus Clarke freebsd_committer 2019-04-12 20:40:26 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer 2019-04-12 20:40:37 UTC
A commit references this bug:

Author: marcus
Date: Fri Apr 12 20:39:44 UTC 2019
New revision: 498743
URL: https://svnweb.freebsd.org/changeset/ports/498743

Log:
  Switch to using default Python only for DBUS file generation.

  PR:		237199
  Submitted by:	gahr

Changes:
  head/net-im/libpurple/Makefile