Bug 237379

Summary: www/rubygem-rails4: Remove bundler dependency pin on bundler < 2.0
Product: Ports & Packages Reporter: Koichiro Iwao <meta>
Component: Individual Port(s)Assignee: freebsd-ruby (Nobody) <ruby>
Status: Closed FIXED    
Severity: Affects Only Me CC: meta, mfechner
Priority: --- Flags: bugzilla: maintainer-feedback? (ruby)
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237384
Bug Depends on:    
Bug Blocks: 235796    
Attachments:
Description Flags
patch
none
patch-gemspec
none
patch-gemspec
none
patch-gemspec none

Description Koichiro Iwao freebsd_committer 2019-04-19 07:50:29 UTC
Created attachment 203787 [details]
patch

Rails 4.2.11.1 depends on bundler >= 1.3.0 && < 2.0.

https://github.com/rails/rails/blob/v4.2.11.1/rails.gemspec#L30
Comment 1 Matthias Fechner freebsd_committer 2019-04-19 09:18:53 UTC
I'm not sure if this is really required.
Regarding:
https://bundler.io/whats_new.html

Bundler version 2 switches automatically between version 1 and 2 depending on the lockfile.
Maybe patching in this case rails4 and remove the < 2.0 is also an options, but should be tested.
Comment 2 Koichiro Iwao freebsd_committer 2019-04-19 09:44:05 UTC
For the record, I got this without this patch. As you say, patching to gemspec will work.

====> Compressing man pages (compress-man)
====> Running Q/A tests (stage-qa)
Error: RubyGem dependency bundler < 2.0 is not satisfied.
*** Error code 1

Stop.
make[1]: stopped in /home/meta/FreeBSD/ports/head/www/rubygem-rails4
*** Error code 1
Comment 3 Koichiro Iwao freebsd_committer 2019-04-19 09:57:03 UTC
Created attachment 203793 [details]
patch-gemspec

I tested another option, I still got this:

====> Compressing man pages (compress-man)
====> Running Q/A tests (stage-qa)
Error: RubyGem dependency bundler < 2.0 is not satisfied.
*** Error code 1

Stop.
make[1]: stopped in /home/meta/FreeBSD/ports/head/www/rubygem-rails4
*** Error code 1

Stop.
make: stopped in /home/meta/FreeBSD/ports/head/www/rubygem-rails4
Comment 4 Koichiro Iwao freebsd_committer 2019-04-19 10:11:37 UTC
Created attachment 203794 [details]
patch-gemspec

The previous patch-gemspec is not complete, this builds fine.
Comment 5 Koichiro Iwao freebsd_committer 2019-04-19 10:13:00 UTC
Created attachment 203795 [details]
patch-gemspec

Oops, removed debugging make target.
Comment 6 Matthias Fechner freebsd_committer 2019-04-19 10:27:08 UTC
Good that is what I meant.
Now it is time to make some tests on Ports using this port to see if they break by this modification. Maybe redmine would by a candidate for this.
Comment 7 Koichiro Iwao freebsd_committer 2019-04-19 11:32:01 UTC
Comment on attachment 203787 [details]
patch

gemspec patch looks better. obsoleting this.
gemspec patch needs to bump PORTREVISION.
Comment 8 Matthias Fechner freebsd_committer 2019-04-19 12:15:23 UTC
All PRs you created are looking fine for me.
If you think you do not break anything, please continue to commit them all.
Comment 9 commit-hook freebsd_committer 2019-04-20 08:41:31 UTC
A commit references this bug:

Author: meta
Date: Sat Apr 20 08:41:22 UTC 2019
New revision: 499429
URL: https://svnweb.freebsd.org/changeset/ports/499429

Log:
  www/rubygem-rails4: Remove bundler dependency pin on bundler < 2.0

  To adapt upcoming update of sysutils/rubygem-bundler to 2.0.1.

  PR:		237379
  Submitted by:	meta (myself)
  Reviewed by:	mfechner

Changes:
  head/www/rubygem-rails4/Makefile
  head/www/rubygem-rails4/files/
  head/www/rubygem-rails4/files/patch-gemspec
Comment 10 Koichiro Iwao freebsd_committer 2019-04-20 08:46:49 UTC
Committed, thanks for your help.