Bug 237406

Summary: net-p2p/retroshare: Fails to build with upnp 1.8.x
Product: Ports & Packages Reporter: Tobias Kortkamp <tobik>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Only Me CC: peter
Priority: --- Flags: peter: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://people.freebsd.org/~tobik/logs/112i386-upnp18/retroshare-0.6.4_2.log
See Also: https://github.com/RetroShare/RetroShare/issues/1498
Bug Depends on:    
Bug Blocks: 234669    
Attachments:
Description Flags
retroshare.diff tobik: maintainer-approval? (peter)

Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-04-20 09:08:44 UTC
Can you help fix it?

In file included from rsserver/rsinit.cc:779:
In file included from ./upnp/upnphandler_linux.h:13:
./upnp/UPnPBase.h:35:10: fatal error: 'upnp/upnpdebug.h' file not found
#include <upnp/upnpdebug.h>
         ^~~~~~~~~~~~~~~~~~
11 warnings and 1 error generated.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2019-04-20 14:54:13 UTC
Created attachment 203830 [details]
retroshare.diff

One possible solution/workaround proposed in the upstream issue is
to switch to miniupnpc.  Here's a patch to do that.
Comment 2 peter 2019-04-22 07:23:27 UTC
Looks good to me.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-04-22 08:27:54 UTC
A commit references this bug:

Author: tobik
Date: Mon Apr 22 08:27:00 UTC 2019
New revision: 499614
URL: https://svnweb.freebsd.org/changeset/ports/499614

Log:
  net-p2p/retroshare: Switch from devel/upnp to net/miniupnpc

  RetroShare does not build with upnp >= 1.8.  Upstream does not have
  a solution for this yet other than suggesting to switch to using
  miniupnpc as a workaround.

  PR:		237406
  Submitted by:	tobik
  Approved by:	peter@netkey.at (maintainer)

Changes:
  head/net-p2p/retroshare/Makefile
  head/net-p2p/retroshare/files/patch-libretroshare_src_libretroshare.pro
  head/net-p2p/retroshare/files/patch-retroshare-gui_src_retroshare-gui.pro
  head/net-p2p/retroshare/files/patch-retroshare-nogui_src_retroshare-nogui.pro
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2019-04-22 08:28:11 UTC
Committed. Thanks!