Bug 237558

Summary: net/ocserv: fix build with GCC-based architectures
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Piotr Kubaj <pkubaj>
Status: Closed FIXED    
Severity: Affects Only Me CC: cpm
Priority: --- Keywords: patch, patch-ready
Version: LatestFlags: cpm: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch cpm: maintainer-approval+

Description Piotr Kubaj freebsd_committer freebsd_triage 2019-04-25 15:08:58 UTC
Created attachment 204008 [details]
patch

Remove -Wno-implicit-fallthrough from configure.ac. This flag is not supported by base GCC and the port still builds without it with Clang.

Tested on powerpc64 and amd64.
Comment 1 Carlos J. Puga Medina freebsd_committer freebsd_triage 2019-04-26 11:40:15 UTC
Approved!

Please, go ahead and push the commit :)

Thanks, Piotr.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-04-26 16:15:19 UTC
A commit references this bug:

Author: pkubaj
Date: Fri Apr 26 16:14:45 UTC 2019
New revision: 500117
URL: https://svnweb.freebsd.org/changeset/ports/500117

Log:
  net/ocserv: fix build with base GCC

  -Wno-implicit-fallthrough is not supported by GCC 4.2

  PR:		237558
  Approved by:	tcberner (mentor), cpm (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D20075

Changes:
  head/net/ocserv/files/patch-configure.ac
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2019-04-26 19:00:15 UTC
Committed, thanks!