Bug 237607
| Summary: | games/megaglest fails building with clang | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Leon Dietrich <doralitze> | ||||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | monwarez | ||||||
| Priority: | --- | Flags: | monwarez:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
The line you're referring to is just a warning. Actual failure case is a typo in cmake options for VIEWER enabled (-BUILD_MEGAGLEST_MODEL_VIEWER=On should be -DBUILD_MEGAGLEST_MODEL_VIEWER=On). Created attachment 204124 [details]
Patch
Thanks for the patch, indeed it was a typo. Using cmake bool help to prevent this. also nice catch for the ldflags uses. The patch seems to be correct, I am currently launching a build to check that it build with all options enabled. Comment on attachment 204124 [details]
Patch
Tested it pass QA
Comment on attachment 204124 [details]
Patch
I cannot set the maintainer-approval flags,
I approve this patch
A commit references this bug: Author: amdmi3 Date: Mon May 13 21:46:33 UTC 2019 New revision: 501598 URL: https://svnweb.freebsd.org/changeset/ports/501598 Log: - Fix build with VIEWER enabled - Add missing USES - Switch to USES=localbase and opt_CMAKE_BOOL PR: 237607 Reported by: doralitze@chaotikum.org Approved by: monwarez@mailoo.org (maintainer) Changes: head/games/megaglest/Makefile A commit references this bug: Author: amdmi3 Date: Mon May 13 21:48:05 UTC 2019 New revision: 501599 URL: https://svnweb.freebsd.org/changeset/ports/501599 Log: MFH: r501598 - Fix build with VIEWER enabled - Add missing USES - Switch to USES=localbase and opt_CMAKE_BOOL PR: 237607 Reported by: doralitze@chaotikum.org Approved by: monwarez@mailoo.org (maintainer) Approved by: ports-secteam (with hat) Changes: _U branches/2019Q2/ branches/2019Q2/games/megaglest/Makefile |
Created attachment 204067 [details] The build log by poudriere As of 3.13.0_7 megaglest uses clang as a compiler using poudriere by default. However clang isn't capable of building the port. Use GCC instead. Please review the attached build log for further details.