Summary: | astro/gpsbabel: Update to latest 1.6.0 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Conrad Meyer <cem> | ||||||
Component: | Individual Port(s) | Assignee: | Luca Pizzamiglio <pizzamig> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | dev2, lbartoletti, pizzamig | ||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(dev2) pizzamig: maintainer-feedback? (dev2) |
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Conrad Meyer
2019-05-03 15:11:45 UTC
I don't know if there's any reason to create a new gpsbabel15 port or if the primary reason for the gpsbabel14 port was to avoid C++/Qt (which was done in 1.5, IIRC). If the latter, maybe we can just drop gpsbabel14 now? I don't have strong feelings about the older versions. Thanks for notifying. I'm running into some trouble with the GUI option again. Something to do with MAKEFLAGS starting with "w " where w is not a valid (g)make target. The non-GUI version builds OK, but I'll have to look closer on where that "w" comes from before I submit a patch. Thanks Oliver. Can you share your work-in-progress patch and maybe I can investigate a little? I don't use the GUI myself but would be happy to look at the build a little bit to help get this updated. Thanks for reminding me. Most work so far has been establishing that all the patches have been included upstream. Now it fails on not being able to build target "w", the w comes from $(MAKEFLAGS), but I have no idea how it got in there. log: https://heesakkers.info/poudriere/2019-07-12_22h16m54s/build.html patch so far: https://heesakkers.info/poudriere/2019-07-12_22h16m54s/gpsbabel-1.6.0.diff It looks like maybe `environ` is ending up in `MAKEFLAGS`? I'm confused: cd gui ; qmake app.pro && gmake w -- _PKG_CHECKED=1 _PERL5_FROM_BIN=5.28.2 _OSRELEASE=13.0-CURRENT OSVERSION=1300031 OSREL=13.0 OPSYS=FreeBSD HAVE_COMPAT_IA32_KERN=YES\ CONFIG_DONE_GPSBABEL=1 CONFIGURE_MAX_CMD_LEN=262144 ARCH=amd64 .MAKE.LEVEL.ENV=MAKELEVEL Created attachment 216048 [details]
fix gpsbabel with Qt GUI
Can you try this patch with GUI? It still needs to be polished (missing Qt include etc.) but should works.
Trying... Thanks Loïc! Note: I no longer use FreeBSD as a desktop, so any testing on my part will be limited. If it comes through Poudriere cleanly, I'm inclined to let the patch through as is. Created attachment 216262 [details]
Proposed patch
Basically Loïcs patch.
Tested, builds and runs. Just added a patch on the gpsbabel.desktop file to accommodate for the new binary name.
It doesn't build with the default value of GUI option [disabled]. Please fix the default build, at least I found the easy fix: I added qmake_build to USE_QT I'm going to commit it with the fix A commit references this bug: Author: pizzamig Date: Sat Jul 11 19:13:01 UTC 2020 New revision: 542043 URL: https://svnweb.freebsd.org/changeset/ports/542043 Log: astro/gpsbabel: Update to latest 1.6.0 Changes: https://www.gpsbabel.org/news/gpsbabel-1.6.0.html PR: 237733 Submitted by: Conrad Meyer <cem@freebsd.org> Approved by: dev2@heesakkers.info (maintainer) Event: July 2020 Bugathon Changes: head/astro/gpsbabel/Makefile head/astro/gpsbabel/distinfo head/astro/gpsbabel/files/patch-Makefile.in head/astro/gpsbabel/files/patch-bushnell.cc head/astro/gpsbabel/files/patch-garmin__device__xml.cc head/astro/gpsbabel/files/patch-gpx.cc head/astro/gpsbabel/files/patch-gui_gpsbabel.desktop head/astro/gpsbabel/files/patch-jeeps_gpslibusb.cc head/astro/gpsbabel/files/patch-lowranceusr.cc head/astro/gpsbabel/files/patch-magproto.cc head/astro/gpsbabel/files/patch-psitrex.cc head/astro/gpsbabel/files/patch-src_core_ziparchive.cc head/astro/gpsbabel/files/patch-src_core_ziparchive.h head/astro/gpsbabel/files/patch-tef_xml.cc head/astro/gpsbabel/files/patch-unicsv.cc head/astro/gpsbabel/pkg-plist Committed! Thanks to all involved. |