Bug 237733

Summary: astro/gpsbabel: Update to latest 1.6.0
Product: Ports & Packages Reporter: Conrad Meyer <cem>
Component: Individual Port(s)Assignee: freebsd-ports-bugs mailing list <ports-bugs>
Status: New ---    
Severity: Affects Only Me CC: dev2
Priority: --- Flags: bugzilla: maintainer-feedback? (dev2)
Version: Latest   
Hardware: Any   
OS: Any   

Description Conrad Meyer freebsd_committer 2019-05-03 15:11:45 UTC
Upstream has released a new version yesterday:

https://www.gpsbabel.org/download.html

And Fedora has already got pending as an update:

https://bugzilla.redhat.com/show_bug.cgi?id=1705691

:-)
Comment 1 Conrad Meyer freebsd_committer 2019-05-03 15:13:12 UTC
I don't know if there's any reason to create a new gpsbabel15 port or if the primary reason for the gpsbabel14 port was to avoid C++/Qt (which was done in 1.5, IIRC).  If the latter, maybe we can just drop gpsbabel14 now?  I don't have strong feelings about the older versions.
Comment 2 Oliver Heesakkers 2019-06-03 13:13:12 UTC
Thanks for notifying.

I'm running into some trouble with the GUI option again. Something to do with  MAKEFLAGS starting with "w " where w is not a valid (g)make target.

The non-GUI version builds OK, but I'll have to look closer on where that "w" comes from before I submit a patch.
Comment 3 Conrad Meyer freebsd_committer 2019-07-12 20:08:02 UTC
Thanks Oliver.  Can you share your work-in-progress patch and maybe I can investigate a little?  I don't use the GUI myself but would be happy to look at the build a little bit to help get this updated.
Comment 4 Oliver Heesakkers 2019-07-12 20:32:56 UTC
Thanks for reminding me.

Most work so far has been establishing that all the patches have been included upstream.

Now it fails on not being able to build target "w", the w comes from $(MAKEFLAGS), but I have no idea how it got in there.

log:
https://heesakkers.info/poudriere/2019-07-12_22h16m54s/build.html

patch so far:
https://heesakkers.info/poudriere/2019-07-12_22h16m54s/gpsbabel-1.6.0.diff
Comment 5 Conrad Meyer freebsd_committer 2019-07-16 00:54:21 UTC
It looks like maybe `environ` is ending up in `MAKEFLAGS`?  I'm confused:

cd gui ; qmake app.pro && gmake w -- _PKG_CHECKED=1 _PERL5_FROM_BIN=5.28.2 _OSRELEASE=13.0-CURRENT OSVERSION=1300031 OSREL=13.0 OPSYS=FreeBSD HAVE_COMPAT_IA32_KERN=YES\  CONFIG_DONE_GPSBABEL=1 CONFIGURE_MAX_CMD_LEN=262144 ARCH=amd64 .MAKE.LEVEL.ENV=MAKELEVEL