Bug 237847

Summary: graphics/opencv: Update to 4.1.0
Product: Ports & Packages Reporter: Hiroo Ono <hiroo.ono+freebsd>
Component: Individual Port(s)Assignee: Tobias C. Berner <tcberner>
Status: Closed FIXED    
Severity: Affects Only Me CC: ari, hiroo.ono+freebsd, lwhsu, pi, pkubaj, rhurlin, rodrigo, trueos, vvd
Priority: --- Keywords: needs-qa
Version: LatestFlags: koobs: maintainer-feedback? (hiroo.ono+freebsd)
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237135
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237933
Attachments:
Description Flags
opencv 3.4.1 -> 4.1.0 patch
none
patch to graphics/caffe
none
opencv 3.4.1 -> 4.1.0 patch
none
patch to astro/siril to depend on opencv4
none
patch to ports that depends on opencv4 none

Description Hiroo Ono 2019-05-12 07:55:43 UTC 
Created attachment 204333 [details]
opencv 3.4.1 -> 4.1.0 patch

This is a patch to update graphics/opencv (and related) ports to 4.1.0.
It is related to bug #237135 which copies graphics/opencv to graphics/opencv3 and updates to 3.4.6.
This patch creates one more slave port graphics/opencv-contrib to avoid circular dependency between graphics/caffe.

To be able to install opencv3 and opencv4 at the same time, I moved include files and libraries to subdirectory of ${LOCALBASE}/include and ${LOCALBASE}/lib. As a consequent, about 40 ports dependent on graphics/opencv need to be patched. The patch to graphics/caffe follows and multimedia/ffmpeg is dealt in the bug #237135, but the patches for other ports are not ready.

Problem: I did not add CONFLICTS, but graphics/py-opencv and graphics/py-opencv3 install the library files to the same location, and cannot coexists. Is there any way for both versions to coexist?
Comment 1 Hiroo Ono 2019-05-12 07:57:04 UTC 
Created attachment 204334 [details]
patch to graphics/caffe

Patch to graphics/caffe depended by graphics/opencv-contrib if option CAFFE is enabled.
Comment 2 Hiroo Ono 2019-05-22 15:36:05 UTC 
Created attachment 204542 [details]
opencv 3.4.1 -> 4.1.0 patch

Some correction to the patch:

- With IPP option, a little more patching was needed.
- Restored NONFREE option.
Comment 3 Hiroo Ono 2019-05-22 15:37:11 UTC 
Created attachment 204543 [details]
patch to astro/siril to depend on opencv4
Comment 4 Hiroo Ono 2019-05-22 15:42:03 UTC 
Created attachment 204544 [details]
patch to ports that depends on opencv4

Among the ports in categories astro or graphics, that depend on graphics/opencv(-core), these ports could be built with opencv4:

astro/siril (separate patch)
graphics/caffe (separate patch)
graphics/digikam
graphics/nomacs
graphics/openimageio
graphics/waifu2x-converter-cpp
graphics/yafaray
Comment 5 Rodrigo Osorio freebsd_committer freebsd_triage 2019-08-12 11:12:37 UTC 
Can't help with this port, back to the pool
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2019-09-25 20:59:58 UTC 
4.1.1 released already.
Comment 7 Ari Suutari 2020-01-16 07:43:22 UTC 
Anyone planning any activity on this ? I tried to apply 
opencv 3.4.1 -> 4.1.0 patch from here, but it seems that other
changes have made it a little bit difficult to apply.

4.1 version might be helpful for python use cases that use also tensorflow.
Comment 8 Li-Wen Hsu freebsd_committer freebsd_triage 2020-07-02 04:16:57 UTC 
Hiroo: do you want to maintain the graphics/opencv port?
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2020-07-03 02:29:54 UTC 
^Triage: 

- [tags] in issue Titles are deprecated
- If any referenced issues are blocked by or depend on this issue, please add them to this issues Blocked By or Depends On fields accordingly
- Track feedback request from Hiroo (comment 9)
Comment 10 Hiroo Ono 2020-11-23 10:20:09 UTC 
(In reply to Li-Wen Hsu from comment #8)
Currently, no. I do not have enough time to rework the patch. I want to try to update the patch later, but I have to address the problem stated in #237933 then.
Comment 11 Kurt Jaeger freebsd_committer freebsd_triage 2020-12-19 15:39:48 UTC 
4.5.0 is out
Comment 12 Tobias C. Berner freebsd_committer freebsd_triage 2021-01-30 18:11:42 UTC 
Overcome by https://svnweb.freebsd.org/ports?view=revision&revision=563430