Bug 237866

Summary: nvmecontrol(8) 'power [-w workload_hint] is undocumented
Product: Documentation Reporter: Poul-Henning Kamp <phk>
Component: Manual PagesAssignee: Warner Losh <imp>
Status: Closed FIXED    
Severity: Affects Some People CC: doc, imp
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description Poul-Henning Kamp freebsd_committer freebsd_triage 2019-05-13 07:19:43 UTC
The 'power' command is not documented under DESCRIPTION, but mentioned under EXAMPLES.

The '-w workload_hint' argument is however not documented at all.

This is probably (who knows ?) relevant for laptops with NVME drives.
Comment 1 Warner Losh freebsd_committer freebsd_triage 2021-07-09 18:12:59 UTC
https://reviews.freebsd.org/D31122
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-07-10 16:54:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=445b5554bf97254a0ead3d70f801871d62dcfb62

commit 445b5554bf97254a0ead3d70f801871d62dcfb62
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2021-07-10 16:51:15 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2021-07-10 16:53:34 +0000

    nvmecontrol: document power command

    The description of the power command is missing. While the synopsis is
    present, there's no explanation. Add one.

    Reviewed by:            mav, chuck
    PR:                     237866
    Sponsored by:           Netflix
    Differential Revision:  https://reviews.freebsd.org/D31122

 sbin/nvmecontrol/nvmecontrol.8 | 33 ++++++++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-07-12 19:43:49 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=39d7a1f4790910c990db53a2eb75cba34ab734bf

commit 39d7a1f4790910c990db53a2eb75cba34ab734bf
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2021-07-10 16:51:15 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2021-07-12 19:42:59 +0000

    nvmecontrol: document power command

    The description of the power command is missing. While the synopsis is
    present, there's no explanation. Add one.

    Reviewed by:            mav, chuck
    PR:                     237866
    Sponsored by:           Netflix
    Differential Revision:  https://reviews.freebsd.org/D31122

    (cherry picked from commit 445b5554bf97254a0ead3d70f801871d62dcfb62)

 sbin/nvmecontrol/nvmecontrol.8 | 33 ++++++++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-07-31 05:07:02 UTC
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=4905e7273229106f7fc62d2801f5295d50d718d0

commit 4905e7273229106f7fc62d2801f5295d50d718d0
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2021-07-10 16:51:15 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2021-07-31 05:02:56 +0000

    nvmecontrol: document power command

    The description of the power command is missing. While the synopsis is
    present, there's no explanation. Add one.

    Reviewed by:            mav, chuck
    PR:                     237866
    Sponsored by:           Netflix
    Differential Revision:  https://reviews.freebsd.org/D31122

    (cherry picked from commit 445b5554bf97254a0ead3d70f801871d62dcfb62)

 sbin/nvmecontrol/nvmecontrol.8 | 33 ++++++++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)