| Summary: | games/supertuxkart: Adds missing security/nettle dependency | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Lorenzo Salvadore <salvadore> | ||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | CC: | amdmi3 | ||||
| Priority: | --- | Flags: | koobs:
merge-quarterly?
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: amdmi3 Date: Mon Jun 3 17:37:13 UTC 2019 New revision: 503404 URL: https://svnweb.freebsd.org/changeset/ports/503404 Log: Add option to switch between Nettle and OpenSSL for cryptography Nettle is used by default in accordance to what upstream CMake code prefers. This fixes hidden dependency on nettle if it's installed when supertuxkart is build. PR: 237923 Reported by: phascolarctos@protonmail.ch MFH: 2019Q2 Changes: head/games/supertuxkart/Makefile Fixed in a bit more flexible manner, thanks for report! NB: This is not really subject to MFH as 2019Q2 still has supertuxkart 0.9.3. Quarterly port version aside, if the quarterly version has a missing dependency (undeclared) then the change should be merged. Given ports r503404 does not increment PORTVERSION, this is a great candidate If quarterly is not affected (doesn't link to libnettle), set merge-quarterly to - |
Created attachment 204400 [details] supertuxkart - adds dependency on security/nettle Supertuxkart binary is linked to libnettle.so, but the dependency is not declared in the port's Makefile, so that pkg autoremove can remove security/nettle making the game unplayable (it happened to me): this patch adds libnettle to LIBDEPENDS. It also bumps PORTREVISION. Tested successfully on 12.0-RELEASE r347628 amd64.