Summary: | print/libraqm: fix build with GCC-based architectures | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||
Component: | Individual Port(s) | Assignee: | Koop Mast <kwm> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | dewayne, kwm | ||||
Priority: | --- | Flags: | kwm:
maintainer-feedback+
|
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
A commit references this bug: Author: pkubaj Date: Fri Jun 14 07:13:01 UTC 2019 New revision: 504166 URL: https://svnweb.freebsd.org/changeset/ports/504166 Log: print/libraqm: fix build with GCC-based architectures Don't shadow global variable index: cc1: warnings being treated as errors raqm.c: In function '_raqm_u32_to_u8_index': raqm.c:1602: warning: declaration of 'index' shadows a global declaration Fails to build with base GCC. PR: 237949 Approved by: kwm (maintainer), mat (mentor) Differential Revision: https://reviews.freebsd.org/D20613 Changes: head/print/libraqm/files/ head/print/libraqm/files/patch-src_raqm.c (In reply to commit-hook from comment #1) A quick data-point. With the patch the package builds on i386 FreeBSD11.3Prerelease using gcc8 (8.3.0) and port's binutils. Interestingly it failed to build with clang 8.0.0 on same machine. |
Created attachment 204427 [details] patch Don't shadow global variable index: cc1: warnings being treated as errors raqm.c: In function '_raqm_u32_to_u8_index': raqm.c:1602: warning: declaration of 'index' shadows a global declaration /usr/include/strings.h:62: warning: shadowed declaration is here raqm.c: In function '_raqm_u8_to_u32_index': raqm.c:1619: warning: declaration of 'index' shadows a global declaration /usr/include/strings.h:62: warning: shadowed declaration is here raqm.c: In function 'raqm_index_to_position': raqm.c:1658: warning: declaration of 'index' shadows a global declaration /usr/include/strings.h:62: warning: shadowed declaration is here raqm.c: In function 'raqm_position_to_index': raqm.c:1752: warning: declaration of 'index' shadows a global declaration /usr/include/strings.h:62: warning: shadowed declaration is here Fails to build with base GCC.