Bug 237971

Summary: sysutils/py-salt: split port into -latest and -stable (2019.2 and 2018.3)
Product: Ports & Packages Reporter: Christer Edwards <christer.edwards>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: python, woodsb02
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247504
Attachments:
Description Flags
py-salt20183 patch
none
py-salt20192 patch
none
py-salt20183@py27 testport
none
py-salt20183@py36 testport
none
py-salt20192@py27 testport
none
py-salt20192@py36 testport none

Description Christer Edwards 2019-05-18 18:22:01 UTC 
Created attachment 204450 [details]
py-salt20183 patch

Per conversation in bug #236054, I am attempting to split the port into -latest and -stable versions. At this time that will represent the 2019.2.x and 2018.3.x branches respectively.

Attached are patches for sysutils/py-salt20183, sysutils/py-salt20192.

These have been tested on @py27 and @py36 versions.

The default version should probably be sysutils/py-salt20183.
Comment 1 Christer Edwards 2019-05-18 18:22:20 UTC 
Created attachment 204451 [details]
py-salt20192 patch
Comment 2 Christer Edwards 2019-05-18 18:22:41 UTC 
Created attachment 204452 [details]
py-salt20183@py27 testport
Comment 3 Christer Edwards 2019-05-18 18:23:06 UTC 
Created attachment 204453 [details]
py-salt20183@py36 testport
Comment 4 Christer Edwards 2019-05-18 18:23:25 UTC 
Created attachment 204454 [details]
py-salt20192@py27 testport
Comment 5 Christer Edwards 2019-05-18 18:23:55 UTC 
Created attachment 204455 [details]
py-salt20192@py36 testport
Comment 6 Ben Woods freebsd_committer freebsd_triage 2020-03-07 04:35:32 UTC 
Hi Christer,

Now that phase 3 upstream support is now finished for 2018.3, can I ask what you would like to do with this bug?
https://www.saltstack.com/product-support-lifecycle/

From a user's point of view, its always nice if you can just keep doing "pkg upgrade", and not have to worry about versions. Am I correct in saying this patch would require the following manual steps from users to upgrade between versions?
# pkg remove py37-salt20183
# pkg install py37-salt20192

Given salt masters and minions should generally be kept in sync, it might make sense for salt to have separate packages in this case, and give the sysadmin fine-grained control over the salt versions being run (using the pkg commands above).

EXTRACT FROM UPSTREAM DOCUMENTATION - UPGRADE INSTRUCTIONS
https://docs.saltstack.com/en/master/topics/installation/index.html#upgrading-salt
"
Upgrading Salt

When upgrading Salt, the master(s) should always be upgraded first. Backward compatibility for minions running newer versions of salt than their masters is not guaranteed.

Whenever possible, backward compatibility between new masters and old minions will be preserved. Generally, the only exception to this policy is in case of a security vulnerability.
"