Bug 237975
| Summary: | Add /usr/lib/libgomp.so symlink on Clang architectures | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Jan Beich <jbeich> | ||||
| Component: | bin | Assignee: | freebsd-toolchain (Nobody) <toolchain> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | dim, linimon, yuri | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | CURRENT | Flags: | dim:
mfc-stable12+
dim: mfc-stable11+ |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 236062 | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: dim Date: Sun May 19 20:13:55 UTC 2019 New revision: 347979 URL: https://svnweb.freebsd.org/changeset/base/347979 Log: To avoid unnecessarily modifying ports, add a -lgomp symlink, since GCC does not ship a -lomp symlink. Also update OptionalObsoleteFiles for this, and add 32-bit variants while here. Submitted by: jbeich PR: 237975 MFC after: 3 days Changes: head/lib/libomp/Makefile head/tools/build/mk/OptionalObsoleteFiles.inc A commit references this bug: Author: dim Date: Wed May 22 17:42:23 UTC 2019 New revision: 348116 URL: https://svnweb.freebsd.org/changeset/base/348116 Log: MFC r347978: Fix OptionalObsoleteFiles copy/paste mistake from r345236, which connected libomp to the build. The comparison should not have been against ${MK_OPENSSH}, but against ${MK_OPENMP}, obviously. MFC r347979: To avoid unnecessarily modifying ports, add a -lgomp symlink, since GCC does not ship a -lomp symlink. Also update OptionalObsoleteFiles for this, and add 32-bit variants while here. Submitted by: jbeich PR: 237975 Changes: _U stable/12/ stable/12/lib/libomp/Makefile stable/12/tools/build/mk/OptionalObsoleteFiles.inc A commit references this bug: Author: dim Date: Wed May 22 19:39:56 UTC 2019 New revision: 348118 URL: https://svnweb.freebsd.org/changeset/base/348118 Log: MFC r347978: Fix OptionalObsoleteFiles copy/paste mistake from r345236, which connected libomp to the build. The comparison should not have been against ${MK_OPENSSH}, but against ${MK_OPENMP}, obviously. MFC r347979: To avoid unnecessarily modifying ports, add a -lgomp symlink, since GCC does not ship a -lomp symlink. Also update OptionalObsoleteFiles for this, and add 32-bit variants while here. Approved by: re (gjb) Submitted by: jbeich PR: 237975 Changes: _U stable/11/ stable/11/lib/libomp/Makefile stable/11/tools/build/mk/OptionalObsoleteFiles.inc FWIW, devel/openmp also provides libiomp5.so symlink for compatibility with the old library name[1]. As only science/openmx was affected I've proposed to fix[2] downstream patch instead. [1] https://reviews.llvm.org/rL238715 [2] https://lists.freebsd.org/pipermail/svn-ports-head/2019-May/209631.html |
Created attachment 204459 [details] fix To avoid unnecessarily modifying ports it'd be nice to have -lgomp symlink since GCC doesn't ship -lomp symlink. $ rg --sort-files -F libgomp.so: graphics/gmic/Makefile 44:OPENMP_LIB_DEPENDS= libgomp.so:devel/openmp lang/J/Makefile 42:OPENMP_LIB_DEPENDS= libgomp.so:lang/gcc7 science/gabedit/Makefile 43:OPENMP_LIB_DEPENDS= libgomp.so:devel/openmp science/py-GPy/Makefile 17:LIB_DEPENDS= libgomp.so:devel/openmp science/py-phono3py/Makefile 22:LIB_DEPENDS= libgomp.so:devel/openmp \