Bug 237984
| Summary: | print/dot2tex: Update to 2.11.3 | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Val Packett <val> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | TAKATSU Tomonari <tota> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | koobs, python | ||||||||||||
| Priority: | --- | Keywords: | needs-qa | ||||||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(tota) |
||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
Has Python 2 support been removed? (In reply to Kubilay Kocak from comment #1) No, but does anyone need this to use Python 2? PYTHON_DEFAULT recently became 3.6 (finally!) so I'd like to remove python2.7 from my system. I can flavorize of course, but that involves new package names and stuff.. (In reply to Greg V from comment #2) USES=python is for declarative, not for imperative use, and must declare all/any versions a package supports. This allows, rather than restricts a user to select what version they want, for packages that support that version. This has no bearing on whether you (or anyone else) can keep Python X on their system or not, in fact, it helps achieve that, by not restrictive Python choices unnecessarily. If dot2tex has supported Python 3 up to this point, its USES=python:<version-spec> up until now has too been unecessarily restricted and incorrectly used. Is this the case or was Python 3 support only added in 2.11.3, the version submitted here? Created attachment 204520 [details] dot2tex.patch v2 (In reply to Kubilay Kocak from comment #3) Yeah it's supported py3 for a long time. Sure, let's go with python without any version, as that accomplishes the goal (I was too slow to realize that…) (In reply to Greg V from comment #4) All good mate. I'm going to make the USES=python change (allowing 2 *and* 3) along with adding a test target if I can (for good QA), as it is a blanket candidate not requiring approval. This also allows us to MFH that change, leaving the update to the maintainer Hmm dot2tex.patch v2 occurs following error. $ make ===> License MIT accepted by the user ===> dot2tex-2.11.3 depends on file: /usr/local/sbin/pkg - found (snip) ====> Compressing man pages (compress-man) ====> Running Q/A tests (stage-qa) Error: Package names are not unique with flavors: py36: dot2tex-2.11.3 py27: dot2tex-2.11.3 Error: maybe use <flavor>_PKGNAMEPREFIX/SUFFIX. *** Error code 1 Stop. make: stopped in /usr/ports/print/dot2tex (In reply to TAKATSU Tomonari from comment #6) Yeah, I saw that as well.. Should it be PYTHON=noflavors? (In reply to Greg V from comment #7) I've fixed that in my WIP, port is missing PYTHONPGNAMEPREFIX, I'll attach something here shortly (In reply to Kubilay Kocak from comment #8) I think noflavors would be better than PKGNAMEPREFIX, changing PKGBASE breaks upgrade for end users. (In reply to Antoine Brodin from comment #9) -O on noflavors, it should be used very sparingly, port should have had PKGNAMEPREFIX (or SUFFIX) from the start, port has zero dependents, and switching ports/packages is trivial, particularly if its in MOVED Created attachment 204604 [details]
A patch to fix an error "Package names are not unique"
(In reply to TAKATSU Tomonari from comment #11) My Wip includes a few more changes/additions. I'll attach it shortly (In reply to Kubilay Kocak from comment #12) Forgot, I need to run through the new test target that I added, which needs latex, which is huge. I'll include the updated patch tomorrow when that is complete and QA is verified Created attachment 204751 [details]
dot2tex-issue-237984.patch
print/dot2tex: Fix incorrect Python version spec
dot2tex supports Python 2 and 3. This change removes the unecessary version
spec restriction to 2.7.
While I'm here:
- Add PKGNAMEPREFIX (unique package names per flavor)
- Enable USE_PYTHON=concurrent, each package flavor installs scripts in
common locations
- Add TEST_DEPENDS/test target
- Add python to CATEGORIES
- Pet portlint (Make file sort/group order)
portlint: OK (looks fine.)
testport: OK (poudriere: 12amd64-py35,py27)
maketest: OK* (Ran 54 tests in 33.863s FAILED (failures=3))
* Note: Previous test suite pass rate unknown, old latex (texlive 2015)
Comment on attachment 204751 [details]
dot2tex-issue-237984.patch
Approved by: portrmgr (maintainer timeout: 1 month)
A commit references this bug: Author: koobs Date: Mon Jul 1 06:56:30 UTC 2019 New revision: 505544 URL: https://svnweb.freebsd.org/changeset/ports/505544 Log: print/dot2tex: Fix incorrect Python version spec dot2tex supports Python 2 and 3. This change removes the unecessary version spec restriction to 2.7. While I'm here: - Add PKGNAMEPREFIX (unique package names per flavor) - Enable USE_PYTHON=concurrent, each package flavor installs scripts in common locations - Add TEST_DEPENDS/test target - Add python to CATEGORIES - Pet portlint (Make file sort/group order) PR: 237984 Approved by: portmgr (maintainer timeout: 1 month) MFH: 2019Q2 (blanket(s): ports (& Python) compliance) Changes: head/print/dot2tex/Makefile A commit references this bug: Author: koobs Date: Mon Jul 1 07:13:53 UTC 2019 New revision: 505547 URL: https://svnweb.freebsd.org/changeset/ports/505547 Log: MFH: r505544 print/dot2tex: Fix incorrect Python version spec dot2tex supports Python 2 and 3. This change removes the unecessary version spec restriction to 2.7. While I'm here: - Add PKGNAMEPREFIX (unique package names per flavor) - Enable USE_PYTHON=concurrent, each package flavor installs scripts in common locations - Add TEST_DEPENDS/test target - Add python to CATEGORIES - Pet portlint (Make file sort/group order) PR: 237984 Approved by: portmgr (maintainer timeout: 1 month) Approved by: ports-secteam (blanket(s): ports (& python) compliance) Changes: _U branches/2019Q2/ branches/2019Q2/print/dot2tex/Makefile Created attachment 205490 [details]
version update only
A commit references this bug: Author: tota Date: Wed Jul 3 22:50:45 UTC 2019 New revision: 505797 URL: https://svnweb.freebsd.org/changeset/ports/505797 Log: - Update to 2.11.3 PR: 237984 Submitted by: Greg V <greg_AT_unrelenting_DOT_technology> Changes: head/print/dot2tex/Makefile head/print/dot2tex/distinfo Committed. Thanks! |
Created attachment 204469 [details] dot2tex.patch