Bug 238066

Summary: graphics/ipe: fix build with GCC-based architectures
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Muhammad Moinur Rahman <bofh>
Status: Closed FIXED    
Severity: Affects Only Me CC: bofh
Priority: --- Flags: bugzilla: maintainer-feedback? (bofh)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch pkubaj: maintainer-approval? (bofh)

Description Piotr Kubaj freebsd_committer freebsd_triage 2019-05-23 07:30:34 UTC 
Created attachment 204561 [details]
patch

Add include limits.h to ipelib/ipeplatform.cpp to find PATH_MAX:
ipeplatform.cpp: In static member function 'static ipe::String ipe::Platform::realPath(ipe::String)':
ipeplatform.cpp:420:14: error: 'PATH_MAX' was not declared in this scope
   char rpath[PATH_MAX];
              ^~~~~~~~
ipeplatform.cpp:420:14: note: suggested alternative: 'INT8_MAX'
   char rpath[PATH_MAX];
              ^~~~~~~~
              INT8_MAX
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-05-29 21:25:01 UTC 
This builds for me, so once the maintainer approves, consider this mentor approval.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-06-11 18:48:28 UTC 
A commit references this bug:

Author: bofh
Date: Tue Jun 11 18:47:33 UTC 2019
New revision: 503974
URL: https://svnweb.freebsd.org/changeset/ports/503974

Log:
  graphics/ipe: fix build with GCC-based architectures

  PR:		238066
  Submitted by:	pkubaj

Changes:
  head/graphics/ipe/Makefile
  head/graphics/ipe/files/patch-ipelib_ipeplatform.cpp
Comment 3 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2019-06-11 18:50:16 UTC 
(In reply to Mark Linimon from comment #1)
I am sorry, I missed this comment. Otherwise I would have let pkubaj commit this one. Happy porting.