Bug 238079
| Summary: | editors/neovim: use Lua instead of LuaJIT on various architectures (aarch64, powerpc64 etc) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Val Packett <val> | ||||
| Component: | Individual Port(s) | Assignee: | Adam Weinberger <adamw> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | val | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(adamw) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 201763 | ||||||
| Attachments: |
|
||||||
|
Description
Val Packett
2019-05-23 17:43:26 UTC
Hi Greg, sorry for the delayed response, I was on vacation. I like the idea but I'm not liking LUAJIT just being a default--people on x86 should always have it enabled. I think OPTIONS_SLAVE_amd64/i386 might work better than just OPTIONS_DEFAULT. I haven't tested that out though. (In reply to Adam Weinberger from comment #1) > people on x86 should always have it enabled Why? It's a valid option. I'm currently using a build with lua 5.2 on amd64 and not planning on going back to luajit. I'd like to get rid of luajit on my system completely. Interesting. I hadn't considered x86 nvim without luajit before, though I see now that you mentioned it in your original PR message too. A commit references this bug: Author: adamw Date: Tue May 28 14:04:35 UTC 2019 New revision: 502895 URL: https://svnweb.freebsd.org/changeset/ports/502895 Log: Disable LuaJIT on non-x86 architectures The version of LuaJIT in port doesn't work well (or at all) for neovim on non-x86 architectures. Plus, some users (at least the submitter, who made a good argument for it) may not want LuaJIT at all. So, make LuaJIT an OPTION. Enable it by default, and exclude it from all the archs that LuaJIT+neovim doesn't work on. Fall back instead on normal Lua. PR: 238079 Submitted by: Greg V MFH: 2019Q2 Changes: head/editors/neovim/Makefile A commit references this bug: Author: adamw Date: Tue May 28 14:08:12 UTC 2019 New revision: 502897 URL: https://svnweb.freebsd.org/changeset/ports/502897 Log: MFH: r500370 r502895 Approved by: portmgr (with hat) Update neovim to 0.3.5 Maintenance release to fix issues found in v0.3.4. options: properly reset directories on 'autochdir' Remove MSVC optimization workaround for SHM_ALL Make SHM_ALL to a variable instead of a compound literal #define doc: mention "pynvim" module rename screen: don't crash when drawing popupmenu with 'rightleft' option look-behind match may use the wrong line number :terminal : set topline based on window height :recover : Fix crash on non-existent *.swp Disable LuaJIT on non-x86 architectures The version of LuaJIT in port doesn't work well (or at all) for neovim on non-x86 architectures. Plus, some users (at least the submitter, who made a good argument for it) may not want LuaJIT at all. So, make LuaJIT an OPTION. Enable it by default, and exclude it from all the archs that LuaJIT+neovim doesn't work on. Fall back instead on normal Lua. PR: 238079 Submitted by: Greg V Changes: _U branches/2019Q2/ branches/2019Q2/editors/neovim/Makefile branches/2019Q2/editors/neovim/distinfo Committed with slight modifications (spacing, changed a few words in the _DESC, and used OPTIONS_DEFAULT instead of per-arch _DEFAULT). Threw in a PORTREVISION bump for good measure, and merged it to quarterly. Thanks for this, Greg! |
