Bug 238183

Summary:	cam/scsi/scsi_sa.c: warnings issued by static analysis
Product:	Base System	Reporter:	Alexey Dokuchaev <danfe>
Component:	kern	Assignee:	freebsd-bugs (Nobody) <bugs>
Status:	Open ---
Severity:	Affects Only Me	CC:	ken, mav, mjacob
Priority:	---	Keywords:	needs-qa
Version:	CURRENT
Hardware:	Any
OS:	Any

Description Alexey Dokuchaev freebsd_committer

2019-05-28 07:26:23 UTC

PVS Studio produces lots of warnings over /usr/src/sys/cam/scsi/scsi_sa.c, but most of them are too noisy and out of scope right now.  Three of them, however, look more sensible and probably worth taking a closer look:

cam/scsi/scsi_sa.c:3216:1: warning: V547 Expression 'softc->last_media_blksize == 0' is always false.

cam/scsi/scsi_sa.c:3550:1: warning: V560 A part of conditional expression is always false: (stream_valid == 0).

cam/scsi/scsi_sa.c:4416:1: warning: V519 The 'error' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 4414, 4416.