Bug 238261
| Summary: | multimedia/vlc: Fix undeclared dependencies | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Lorenzo Salvadore <salvadore> | ||||
| Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | multimedia, riggs | ||||
| Priority: | --- | Keywords: | needs-qa, patch | ||||
| Version: | Latest | Flags: | riggs:
maintainer-feedback+
riggs: merge-quarterly+ |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: riggs Date: Thu Jun 20 16:01:00 UTC 2019 New revision: 504636 URL: https://svnweb.freebsd.org/changeset/ports/504636 Log: Update to upstream release 3.0.7.1; Makefile fixes Details: - Update to newest upstream release 3.0.7.1 - Fix drive-by dependencies, reported in [1] - Introduce new options for JPEG and OGGSPOTS [1] PR: 238261 [1] Reported by: phascolarctos@protonmail.ch [1] MFH: 2019Q2 Changes: head/multimedia/vlc/Makefile head/multimedia/vlc/distinfo head/multimedia/vlc/files/patch-modules_codec_vpx.c head/multimedia/vlc/pkg-plist A commit references this bug: Author: riggs Date: Thu Jun 20 16:29:10 UTC 2019 New revision: 504644 URL: https://svnweb.freebsd.org/changeset/ports/504644 Log: MFH: r504636 Update to upstream release 3.0.7.1; Makefile fixes Details: - Update to newest upstream release 3.0.7.1 - Fix drive-by dependencies, reported in [1] - Introduce new options for JPEG and OGGSPOTS [1] PR: 238261 [1] Reported by: phascolarctos@protonmail.ch [1] Approved by: ports-secteam (riggs) Changes: _U branches/2019Q2/ branches/2019Q2/multimedia/vlc/Makefile branches/2019Q2/multimedia/vlc/distinfo branches/2019Q2/multimedia/vlc/files/patch-modules_codec_vpx.c branches/2019Q2/multimedia/vlc/pkg-plist Committed a variant with the vlc update in r504636. (Transitive dependencies, e.g. speexdsp are not necessary, since speex cannot live without it) Thank you! |
Created attachment 204740 [details] vlc - fixes undeclared dependencies Compiling the port with DEVELOPER=yes revealed some implicit dependencies. Using poudriere I tried to spot all of them and fix them. Here is a short description of the patch: - Adds security/libgpg-error and textproc/libebml to LIB_DEPENDS. - Defines three new options -- GSTREAMER, JPEG, OGGSPOTS -- enabled by default. Those are necessary because otherwise the configure script will automatically choose if enabling the corresponding features or not, making dependencies difficult to track. - Adds USE_GNOME=cairo when LIBSVG2 is on or NOTIFY is on. - Adds SDL_USES=sdl since USE_SDL alone is deprecated. - Adds dependency on audio/speexdsp when SPEEX is on. - Adds VDPAU_USE= XORG=sm,ice,x11. - Bumps PORTREVISION. Tested successfully with poudriere on 12.0-RELEASE amd64, but since the port has many options and my macchine is slow, I could not test all cases and I suggest to test it more.