Bug 238290
| Summary: | net-im/coyim: Fix missing version number in "About" dialog | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Santhosh Raju <santhosh.raju> | ||||||
| Component: | Individual Port(s) | Assignee: | Steve Wills <swills> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | Keywords: | easy, needs-qa | ||||||
| Priority: | --- | Flags: | koobs:
merge-quarterly?
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Thank you for the patch Santhosh You should be able to use USES=shebangfix instead of the custom post-patch target to fix the bash shebang. Worth giving it a go (In reply to Kubilay Kocak from comment #1) Oh I did not know about this, thanks for letting me know. Let me make the change and test it out. Will post the updated patch once I make the changes and test it out successfully. Created attachment 204784 [details] Fixes the version number displayed in the "About" dialog box (Now uses shebangfix). (In reply to Kubilay Kocak from comment #1) I have made the changes and now it uses the "shebangfix" instead of doing a custom post-patch search and replace. The new patch attached address this issue and I can confirm the builds are working as expected. Let me know if the patch looks good to be applied. A commit references this bug: Author: swills Date: Sat Jun 8 00:51:36 UTC 2019 New revision: 503688 URL: https://svnweb.freebsd.org/changeset/ports/503688 Log: net-im/coyim: Fix missing version number in About dialog PR: 238290 Submitted by: Santhosh Raju <santhosh.raju@gmail.com> (maintainer) Changes: head/net-im/coyim/Makefile Committed, thanks! |
Created attachment 204781 [details] Fixes the version number displayed in the "About" dialog box. The "About" dialog does not display the version number because of a missing version number file which was not generated during the build. This patch addresses this issue and now generates the above mentioned version file before starting the build. It would be nice if the patch can be applied to the ports tree of FreeBSD. Regards Santhosh