Bug 238356
| Summary: | www/dillo2 distinfo needs a refresh | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | tigersharke | ||||||||
| Component: | Individual Port(s) | Assignee: | Steve Wills <swills> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Many People | CC: | salvadore | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
|
Description
tigersharke
2019-06-06 02:28:03 UTC
I'm working on it. I'll soon post here a patch with some more improvements. Created attachment 204853 [details]
dillo2 - various improvements and adoption
It is ready. Here is a summary of the changes:
- Refreshes distinfo as requested.
- Adds many needed dependencies that were missing (png, fontconfig, jpeg, xorg: x11, xcursor, xext, xfixes, xft, xinerama, xrender).
- Removes conflicts: the conflicting ports do not exist anymore.
- Adds a DEBUG option. An optional debug support was already included, but was implemented differently.
- Removes SSL option. At the moment it does not work and it probably will never work.
- I adopt the port.
- Bumps PORTREVISION.
I might try later to get SSL working, but considering that dillo is not actively developed (last version is from 2013), I doubt the SSL support will ever exit from experimal state.
Moreover, it looks like it uses an old version of openssl (1.0.2 or below). Of course new version of openssl has at least some retrocompatibility feature, but it is unsure it will be enough.
Tested successfully with poudriere on {11.2,12.0}-RELEASE {i386,amd64} and on 12.0-STABLE r348603.
Created attachment 204869 [details] dillo2 - various improvements and adoption I saw that in bug #233985 ndowens had already solved the SSL problem. So I add his solution to the patch. I tested SSL with poudriere on {11.2,12.0}-RELEASE amd64 successfully, but the test failed on 12.0-RELEASE i386 (I haven't yet tried on 11.2 yet). Probably it just needs -lthr.
I am a bit busy in these days, but I should be able to fix it on Monday if not earlier.
Created attachment 204891 [details]
dillo - various improvements and adoption
I managed to do everything this evening. Here is the summary of the new changes:
- Merge ndowens patch for SSL and adds LDFLAGS=-lthr (needed on i386, does not hurt elsewhere).
- Support for png and jpeg is now optional.
- Adds CONFIGURE_ARGS+= --disable-efence --disable-insure. The port does not implement those options at the moment. They are disabled by default by the configure script, but it is safer to specify it.
- Moves www/dillo2 to www/dillo: no other dillos exist anymore.
I tested successfully with poudriere on {11.2,12.0}-RELEASE {i386,amd64}. If no other issues are found it is ready to be commited.
A commit references this bug: Author: swills Date: Fri Jun 7 23:52:20 UTC 2019 New revision: 503677 URL: https://svnweb.freebsd.org/changeset/ports/503677 Log: www/dillo2: various improvements and adoption [1] - Refresh distinfo [1] - Fix SSL [2] - Add missing dependencies [1] - Assign maintainer to submitter [1] - Make PNG and JPEG support optional [1] PR: 238356 [1] PR: 233985 [2] Submitted by: Lorenzo Salvadore <phascolarctos@protonmail.ch> [1] Submitted by: Nathan <ndowens@yahoo.com> [2] Reported by: tigersharke@gmail.com [1] Reported by: jhibbits [2] Changes: head/www/dillo2/Makefile head/www/dillo2/distinfo head/www/dillo2/files/ head/www/dillo2/files/extra-patches-openssl Committed, thanks! |
