Bug 238427
| Summary: | security/py-fail2ban: Add support for py-inotify | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmitry Wagin <dmitry.wagin> | ||||||
| Component: | Individual Port(s) | Assignee: | Kai Knoblich <kai> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | kai, theis | ||||||
| Priority: | --- | Keywords: | easy, patch | ||||||
| Version: | Latest | Flags: | theis:
maintainer-feedback+
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
OK, and thank you for the patch Created attachment 205090 [details]
py-fail2ban-enable-inotify-support-via-option.patch
Thank you both for the patch and the approval. I would introduce the new dependency for devel/py-pyinotify as an option because it's not a mandatory requirement for security/py-fail2ban to make it run.
Users have then choice to opt-in/-out the support for devel/py-pyinotify if they're not comfortable with it.
@maintainer: Can you please give me a short feedback if this minor change based on Dmitri's initial patch is ok for you?
A commit references this bug: Author: kai Date: Sun Jun 16 10:14:21 UTC 2019 New revision: 504294 URL: https://svnweb.freebsd.org/changeset/ports/504294 Log: security/py-fail2ban: Add support for devel/py-pyinotify * Enable support for devel/py-pyinotify that itself uses devel/libinotify to monitor changes in the filesystem. [1] * Also introduce the new dependency as an additional default option INOTIFY while I'm here because it's not a hard requirement for runtime. [2] PR: 238427 Submitted by: Dmitry Wagin <dmitry.wagin@ya.ru> [1] Approved by: theis@gmx.at (maintainer) [1] [2] Changes: head/security/py-fail2ban/Makefile Committed, thank you both for the patch and the quick approval! |
Created attachment 204921 [details] fail2ban.diff The fail2ban service supports both file polling or more efficient file modification notifications