Summary: | net-mgmt/cacti: Update to 1.2.5 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Matthew Horan <matt> | ||||||
Component: | Individual Port(s) | Assignee: | Kai Knoblich <kai> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | freebsd-ports, kai, m.muenz | ||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(freebsd-ports) kai: merge-quarterly+ |
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
URL: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239578 | ||||||||
See Also: | https://github.com/Cacti/cacti/pull/2638 | ||||||||
Attachments: |
|
Description
Matthew Horan
2019-06-09 12:30:56 UTC
Hi, Any progress here? I have a finished diff for update to 1.2.5 with changes Matthew mentioned. Created attachment 206076 [details]
update to 1.2.5
*** Bug 239578 has been marked as a duplicate of this bug. *** Created attachment 206696 [details] cacti-1.2.5_3.diff Attached the latest diff from bug #239578 (that has been marked as duplicate). A commit references this bug: Author: kai Date: Mon Aug 19 20:25:29 UTC 2019 New revision: 509310 URL: https://svnweb.freebsd.org/changeset/ports/509310 Log: net-mgmt/cacti: Update to 1.2.5 * Remove the SNMPBIN option that was introduced with r490477 and which is no longer required since the 1.2.4 release. It was used as a workaround to override the internal PHP SNMP calls which led to graphs that didn't update within cacti. The PHP SNMP extension can now be enabled/disabled by a re-purposed variable in the configuration file. While I'm here: * Remove superfluous "+=" from PLIST_SUB and SUB_LIST because there are no previous definitions of those variables. * Remove CONFLICTS_INSTALL as net-mgmt/cacti88 is no longer present in the Ports tree since the end of 2018. Changes since 1.2.3: https://github.com/Cacti/cacti/blob/release/1.2.5/CHANGELOG PR: 238434 Submitted by: Michael Muenz <m.muenz@gmail.com> Reported by: Matthew Horan <matt@matthoran.com> Approved by: maintainer timeout (2+ months) MFH: 2019Q3 Changes: head/net-mgmt/cacti/Makefile head/net-mgmt/cacti/distinfo head/net-mgmt/cacti/files/extra-patch-lib_snmp.php head/net-mgmt/cacti/files/patch-install__functions.php head/net-mgmt/cacti/files/patch-lib_installer.php head/net-mgmt/cacti/files/pkg-message.in head/net-mgmt/cacti/pkg-plist Comment on attachment 206696 [details] cacti-1.2.5_3.diff Approved by: maintainer timeout (+2 months this PR, +2 weeks from duplicate bug #239578) Committed to the head branch, thank you for reporting and the change at upstream, Matthew! Thanks also to Michael for submitting the patch for the Ports tree! Still waiting for approval from the ports-secteam to commit the changes to the 2019Q3 branch. A commit references this bug: Author: kai Date: Wed Aug 21 07:47:45 UTC 2019 New revision: 509495 URL: https://svnweb.freebsd.org/changeset/ports/509495 Log: MFH: r509310 net-mgmt/cacti: Update to 1.2.5 * Remove the SNMPBIN option that was introduced with r490477 and which is no longer required since the 1.2.4 release. It was used as a workaround to override the internal PHP SNMP calls which led to graphs that didn't update within cacti. The PHP SNMP extension can now be enabled/disabled by a re-purposed variable in the configuration file. While I'm here: * Remove superfluous "+=" from PLIST_SUB and SUB_LIST because there are no previous definitions of those variables. * Remove CONFLICTS_INSTALL as net-mgmt/cacti88 is no longer present in the Ports tree since the end of 2018. Changes since 1.2.3: https://github.com/Cacti/cacti/blob/release/1.2.5/CHANGELOG * Merge the UCL convertions from r508903 while I'm here. PR: 238434 Submitted by: Michael Muenz <m.muenz@gmail.com> Reported by: Matthew Horan <matt@matthoran.com> Approved by: maintainer timeout (2+ months) Approved by: ports-secteam (joneum) Changes: _U branches/2019Q3/ branches/2019Q3/net-mgmt/cacti/Makefile branches/2019Q3/net-mgmt/cacti/distinfo branches/2019Q3/net-mgmt/cacti/files/extra-patch-lib_snmp.php branches/2019Q3/net-mgmt/cacti/files/patch-install__functions.php branches/2019Q3/net-mgmt/cacti/files/patch-lib_installer.php branches/2019Q3/net-mgmt/cacti/files/pkg-message.in branches/2019Q3/net-mgmt/cacti/pkg-plist Committed to the 2019Q3 branch, all done! Thanks for your time you all investigated, great community effort :) |