Bug 238548
| Summary: | devel/dbus: non-default TMPDIR pollutes build products | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Hein <jcfyecrayz> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-gnome (Nobody) <gnome> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | 0mp, gnome | ||||
| Priority: | --- | Keywords: | patch-ready | ||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(gnome) |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Thanks for the patch! A commit references this bug: Author: 0mp Date: Sat Oct 3 17:02:18 UTC 2020 New revision: 551331 URL: https://svnweb.freebsd.org/changeset/ports/551331 Log: devel/dbus: Do not pollute build products when TMPDIR is not /tmp If you have a TMPDIR in your environment that points to an existing directory other than /tmp (e.g., TMPDIR=/bigfilesystem/tmp), when you build devel/dbus, a couple files get built with that value. When the package is installed on a target system that may not have the non-default TMPDIR used at build time, then you will get run-time errors. Such as: % dbus-launch sh Failed to start message bus: Failed to bind socket "/bigfilesystem/tmp/dbus-1nT4MYueXb": No such file or directory EOF in dbus-launch reading address from bus daemon PR: 238548 Submitted by: John Hein <jcfyecrayz@liamekaens.com> Changes: head/devel/dbus/Makefile The issue has been fixed. Thanks! |
Created attachment 205039 [details] [patch] fix for non-default TMPDIR leakage If you have a TMPDIR in your environment that points to an existing directory other than /tmp (e.g., TMPDIR=/bigfilesystem/tmp), when you build devel/dbus, a couple files get built with that value. The affected files are share/dbus-1/session.conf and bin/dbus-cleanup-sockets. When the package is installed on a target system that may not have the non-default TMPDIR used at build time, then you will get run-time errors. Such as: % dbus-launch sh Failed to start message bus: Failed to bind socket "/bigfilesystem/tmp/dbus-1nT4MYueXb": No such file or directory EOF in dbus-launch reading address from bus daemon Attached is a patch to insulate the build from non-default TMPDIR in the build environment. This should not change the package at all if the build host did not have a non-default TMPDIR, so there's no great need to bump PORTREVISION, but you could.