Bug 238646

Summary: qlnx: qlnxe: Fix kernel address leakage in qlnx_rdma.c
Product: Base System Reporter: Fuqian <huangfq.daxian>
Component: kernAssignee: Kevin Bowling <kbowling>
Status: Closed FIXED    
Severity: Affects Some People CC: info, kbowling
Priority: --- Keywords: patch
Version: CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
The patch file none

Description Fuqian 2019-06-17 07:20:16 UTC
Created attachment 205166 [details]
The patch file

In function qlnx_rdma_deregister_if,
the address of object rdma_if will be printed out.
rdma_if is the address of a global variable qlnxr_drv,
which is passed from dev/qlnx/qlnxr/qlnxr_os.c
A kernel address leakage happens.
Fix this by removing the printf statement.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-05-28 05:47:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=9370f49ad1c4625cd73c4d84d3e42ed3e20fabbf

commit 9370f49ad1c4625cd73c4d84d3e42ed3e20fabbf
Author:     Fuqian Huang <huangfq.daxian@gmail.com>
AuthorDate: 2024-05-28 05:45:52 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-05-28 05:45:52 +0000

    qlnx: qlnxe: Fix kernel address leakage

    In function qlnx_rdma_deregister_if,
    the address of object rdma_if will be printed out.
    rdma_if is the address of a global variable qlnxr_drv,
    which is passed from dev/qlnx/qlnxr/qlnxr_os.c
    A kernel address leakage happens.
    Fix this by removing the printf statement.

    PR:             238646
    MFC after:      1 week

 sys/dev/qlnx/qlnxe/qlnx_rdma.c | 3 ---
 1 file changed, 3 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-06-07 05:50:21 UTC
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=e84a661d5418790ac89113aa21d87901c627529f

commit e84a661d5418790ac89113aa21d87901c627529f
Author:     Fuqian Huang <huangfq.daxian@gmail.com>
AuthorDate: 2024-05-28 05:45:52 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-06-07 05:48:21 +0000

    qlnx: qlnxe: Fix kernel address leakage

    In function qlnx_rdma_deregister_if,
    the address of object rdma_if will be printed out.
    rdma_if is the address of a global variable qlnxr_drv,
    which is passed from dev/qlnx/qlnxr/qlnxr_os.c
    A kernel address leakage happens.
    Fix this by removing the printf statement.

    PR:             238646

    (cherry picked from commit 9370f49ad1c4625cd73c4d84d3e42ed3e20fabbf)

 sys/dev/qlnx/qlnxe/qlnx_rdma.c | 3 ---
 1 file changed, 3 deletions(-)