Bug 238655

Summary: qlxgbe: replace device_printf with QL_DPRINT2 in ql_os.c
Product: Base System Reporter: Fuqian <huangfq.daxian>
Component: kernAssignee: Kevin Bowling <kbowling>
Status: Closed FIXED    
Severity: Affects Some People CC: kbowling
Priority: --- Keywords: patch
Version: CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
The patch file none

Description Fuqian 2019-06-17 11:23:53 UTC
Created attachment 205173 [details]
The patch file

QL_DPRINT2 checks the debug level first and then prints.
Replace device_printf with QL_DPRINT2 to check debug level
first before printing out the kernel pointers.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-05-28 05:33:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=3d6c7ee87e9d7f3c8f617c3803af3effa8eb8a16

commit 3d6c7ee87e9d7f3c8f617c3803af3effa8eb8a16
Author:     Fuqian Huang <huangfq.daxian@gmail.com>
AuthorDate: 2024-05-28 05:31:03 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-05-28 05:32:16 +0000

    qlxgbe: fix debug prints in ql_os.c

    QL_DPRINT2 checks the debug level first and then prints.
    Replace device_printf with QL_DPRINT2 to check debug level
    first before printing out the kernel pointers.

    PR:             238655
    MFC after:      1 week

 sys/dev/qlxgbe/ql_os.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-06-07 05:50:24 UTC
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=748fa70c5d12d163e496d033bfd0a5e5919f2df9

commit 748fa70c5d12d163e496d033bfd0a5e5919f2df9
Author:     Fuqian Huang <huangfq.daxian@gmail.com>
AuthorDate: 2024-05-28 05:31:03 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-06-07 05:47:32 +0000

    qlxgbe: fix debug prints in ql_os.c

    QL_DPRINT2 checks the debug level first and then prints.
    Replace device_printf with QL_DPRINT2 to check debug level
    first before printing out the kernel pointers.

    PR:             238655

    (cherry picked from commit 3d6c7ee87e9d7f3c8f617c3803af3effa8eb8a16)

 sys/dev/qlxgbe/ql_os.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)