Bug 238709

Summary:	Please disable direct commits to the github mirror
Product:	Services	Reporter:	Yuri Victorovich <yuri>
Component:	Git Integration	Assignee:	Ulrich Spörlein <uqs>
Status:	Closed Not A Bug
Severity:	Affects Only Me	CC:	uqs
Priority:	---
Version:	unspecified
Hardware:	Any
OS:	Any

Description Yuri Victorovich freebsd_committer

2019-06-19 18:34:17 UTC

I've got the notification of this commit to freebsd/freebsd-ports: https://github.com/freebsd/freebsd-ports/commit/dd442021a18f4fd46726905d6efb81a0e80be862

This is not a pull request, since there are no recent pull requests in this repository. How could this user even commit into this repository?

GitHub comes up with a blank page for the user "jfouquart", and this login is also not in the committers list. So this is somebody from outside.

I don't think that any commits besides PRs should be allowed in this repository.

I am also puzzled by this commit: how could a user who isn't a member be allowed to commit into this repository without a PR? Are permissions set wrong and allow random people to commit? Was this user added to the FreeBSD organization by mistake?

Another odd thing is that it refers to a non-existent port x11/tilix. The subversion log doesn't show that tilix has ever been ported to FreeBSD.

Comment 1 Ulrich Spörlein freebsd_committer

2019-06-19 20:30:31 UTC

The user obviously has no commit access to our repo. What you link to is basically a pull request. Note that the URL you show doesn't have any branch information, so this commit is not part of any branch of our repo.

It is a pull request that you can see here: https://github.com/myfreeweb/freebsd-ports-dank/pull/4


What sort of notification were you getting?

Comment 2 Yuri Victorovich freebsd_committer

2019-06-19 20:42:31 UTC

(In reply to Ulrich Spoerlein from comment #1)

What's confusing is that "dank" isn't mentioned anywhere, only freebsd/freebsd-ports is mentioned. GitHub doesn't have a pull request in this repository, yet it notifies users from this repository about something happening in some other repository as if it happens here.

This port is present there but not in FreeBSD: https://github.com/myfreeweb/freebsd-ports-dank/blob/lite/x11/tilix, which is weird.

Comment 3 Yuri Victorovich freebsd_committer

2019-06-19 20:49:49 UTC

(In reply to Ulrich Spoerlein from comment #1)

> What sort of notification were you getting?

It was just like a comment on the thing I am watching in the repository, except this repository was obviously not our repository.


---------------------------
Hi,

First thanks for porting tilix ( the best terminal emulator for me ).
For the patch in lang/ldc, i'm on freebsd 12 and when i link tilix, i have an intrinsics error on memcpy, this is why i downgrade compiler to clang-6.

PS: sorry for my poor english.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
---- 

The links pointing back to https://github.com/freebsd/freebsd-ports/commit/...

Comment 4 Yuri Victorovich freebsd_committer

2019-06-20 01:01:46 UTC

I believe that this event resulted from some bug in GitHub.
I notified GitHub about this through the private message to their customer service.

Closing this problem here: Not A Bug in FreeBSD's infrastructure.