Bug 238760

Summary: net/quagga: ripd aborts on rip_timeout (1.2.4)
Product: Ports & Packages Reporter: Eugene Grosbein <eugen>
Component: Individual Port(s)Assignee: Eugene Grosbein <eugen>
Status: Closed FIXED    
Severity: Affects Some People CC: eugen
Priority: --- Flags: bugzilla: maintainer-feedback? (pi)
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugzilla.quagga.net/show_bug.cgi?id=1008
https://bugzilla.quagga.net/show_bug.cgi?id=985
Attachments:
Description Flags
Workaround patch none

Description Eugene Grosbein freebsd_committer freebsd_triage 2019-06-22 09:33:16 UTC
Created attachment 205280 [details]
Workaround patch

I see multiple repeatable crashes of ripd triggered by an assert.

The problem was reported upstream over a year ago (2018-04-12) by another person but the PR is still in UNCONFIRMED state there and got no attention:

https://bugzilla.quagga.net/show_bug.cgi?id=985

I reported my own analisys of the problem with workaround patch eliminating crash there:

https://bugzilla.quagga.net/show_bug.cgi?id=1008

However, I doubt it will be resolved upstream in foreseeable future. Please consider adding this patch to the port meantime.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-07-06 14:09:08 UTC
A commit references this bug:

Author: eugen
Date: Sat Jul  6 14:08:36 UTC 2019
New revision: 505996
URL: https://svnweb.freebsd.org/changeset/ports/505996

Log:
  net/quagga: unbreak ripd for 1.2.4

  ripd is essentially non-functional in quagga-1.2.4
  as it aborts on first announce timeout due to some threading logic bug.

  The problem was reported upstream over a year ago and ignored:
  https://bugzilla.quagga.net/show_bug.cgi?id=985
  https://bugzilla.quagga.net/show_bug.cgi?id=1008

  Add work-around that restores ripd stability.

  PR:		238760
  Approved by:	pi (maintainer timeout, 2 weeks)

Changes:
  head/net/quagga/Makefile
  head/net/quagga/files/patch-lib_thread.c
Comment 2 Eugene Grosbein freebsd_committer freebsd_triage 2019-07-06 14:10:04 UTC
Temporary fix committed.