Bug 238794
| Summary: | LAPIC register test failure with OpenBSD 6.5-snapshot guest | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Jason Tubnor <jason> |
| Component: | bhyve | Assignee: | freebsd-virtualization (Nobody) <virtualization> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | CC: | emaste, jhb, markj, rgrimes |
| Priority: | --- | Keywords: | needs-patch, needs-qa |
| Version: | 11.3-RELEASE | Flags: | koobs:
mfc-stable12?
koobs: mfc-stable11? |
| Hardware: | amd64 | ||
| OS: | Any | ||
| URL: | https://reviews.FreeBSD.org/D20755 | ||
|
Description
Jason Tubnor
2019-06-25 03:26:32 UTC
Please try the patch at the phab URL. I have only compile-tested it, but it should emulate the TEST instruction clang is using in this case. D19975 needed to be applied before D20755. Both patched and built correctly. Issue still remains below is the output of bhyve.log: rdmsr to register 0xc80 on vcpu 0 vm_run error -1, errno 22 (In reply to Jason Tubnor from comment #2) In the line of D20755 consisting of "case 0x7F:", could you try replacing 0x7F with 0xF7 and retest? As per comments by markj@ in https://reviews.freebsd.org/D20755 I modified the D20755 patch - switch 7F to F7 and removed struct __hack (the latter is unrelated and worked if it was there or not). Compiled successfully and OpenBSD -current now boots correctly. Please advise when a modified version (with the above changes) hits phabricator and I will download, patch and test. Additional test cases: - Ensure Windows Server 2016 still boots and operates correctly (in progress) - Patch applies to FreeBSD 12.0 - Test OpenBSD -current - Test Windows Server 2016 Confirmed D20755 works with Windows Server 2016 guests. Host: FreeBSD 11.3-RC2 #0 r349252: Fri Jun 21 04:48:05 UTC 2019 root@releng2.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC FreeBSD 12.0-RELEASE-p6 - Confirmed D20755 works (after modifications as per the discussion above). Host: # uname -a FreeBSD testhost 12.0-RELEASE-p6 FreeBSD 12.0-RELEASE-p6 GENERIC amd64 # freebsd-version 12.0-RELEASE-p3 Guests tests: Windows Server 2016 - OK OpenBSD 6.5-current - OK FreeBSD 12.0-p6 - OK A commit references this bug: Author: rgrimes Date: Wed Jun 26 21:19:44 UTC 2019 New revision: 349441 URL: https://svnweb.freebsd.org/changeset/base/349441 Log: Emulate the "TEST r/m{16,32,64}, imm{16,32,32}" instructions (opcode F7H). This adds emulation for: test r/m16, imm16 test r/m32, imm32 test r/m64, imm32 sign-extended to 64 OpenBSD guests compiled with clang 8.0.0 use TEST directly against a Local APIC register instead of separate read via MOV followed by a TEST against the register. PR: 238794 Submitted by: jhb Reported by: Jason Tubnor jason@tubnor.net Tested by: Jason Tubnor jason@tubnor.net Reviewed by: markj, Patrick Mooney patrick.mooney@joyent.com MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D20755 Changes: head/sys/amd64/vmm/vmm_instruction_emul.c A commit references this bug: Author: markj Date: Sun Jul 7 17:30:23 UTC 2019 New revision: 349808 URL: https://svnweb.freebsd.org/changeset/base/349808 Log: MFC r349441 (by rgrimes): Emulate the "TEST r/m{16,32,64}, imm{16,32,32}" instructions (opcode F7H). PR: 238794 Changes: _U stable/12/ stable/12/sys/amd64/vmm/vmm_instruction_emul.c A commit references this bug: Author: markj Date: Sun Jul 7 17:31:13 UTC 2019 New revision: 349809 URL: https://svnweb.freebsd.org/changeset/base/349809 Log: MFC r349441 (by rgrimes): Emulate the "TEST r/m{16,32,64}, imm{16,32,32}" instructions (opcode F7H). PR: 238794 Changes: _U stable/11/ stable/11/sys/amd64/vmm/vmm_instruction_emul.c Planned for release as EN-19:16.bhyve |
