Bug 238879
| Summary: | mail/milter-regex: Postfix not allowed to use socket | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John W. O'Brien <john> | ||||
| Component: | Individual Port(s) | Assignee: | Dirk Meyer <dinoex> | ||||
| Status: | Closed Not Accepted | ||||||
| Severity: | Affects Only Me | CC: | bug, john | ||||
| Priority: | --- | Keywords: | easy, patch, patch-ready | ||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Setting "milterregex_flags" is sufficient to set non default permissions. I reject the UCL part of this patch. (In reply to Dirk Meyer from comment #1) It is not clear where we stand. You indicated your approval with maintainer feedback "+" and expressed your rejection of my patch. (In reply to John W. O'Brien from comment #2) if you hoover over it you see it explained: MAINTAINER feedback: Can mean want/needs/has/no feedback from MAINTAINER: * Set (?) <maintainer-email> to request MAINTAINER feedback * Set (+) when you provide feedback. Avoids 'maintainer timeout' * Set (-) when feedback is not provided. Add comment. Use for 'maintainer timeout' Issues: 1) Your patch removed the default for enable, and the script creates a warning: milterregex: WARNING: $milterregex_enable is not set properly - see rc.conf(5). 2) Your patch moves the defaults from the binary into the command line of the process. This clogs the process views. POLA: We should not have different defaults without reason from the code and from the port. 3) The UCL format of pkg-message makes it hard to read for humans I can't accept the patch in this state. |
Created attachment 205413 [details] mail/milter-regex: Make socket compatible with Postfix The socket milter-regex creates by default is root:mail 0600, which Postfix cannot use. The effect of a previous patch which has since been upstreamed has evidently been undone by other changes. This patch changes the default socket ownership and permissions, and exposes the G P and U options via rc.conf. While here, convert pkg-message to UCL and make minor enhancements. QA == portlint: OK poudriere: OK -- testport on 11.2R amd64