Bug 238884
| Summary: | graphics/caffe: Respect CXX | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||||
| Component: | Individual Port(s) | Assignee: | Piotr Kubaj <pkubaj> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | eric, linimon | ||||||
| Priority: | --- | Flags: | eric:
maintainer-feedback+
koobs: merge-quarterly? |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Reporter is committer, assign accordingly @Piotr Please self-assign yourself to issues you report where maintainer != committer Note also that this change is: Approved by: portmgr (blanket: ports compliance) Comment on attachment 205422 [details]
patch
Set the maintainer-approval flag on attachment (patch) to signify maintainer approval. Attachment -> Details -> maintainer-approval [+]
A commit references this bug: Author: pkubaj Date: Mon Jul 1 19:45:03 UTC 2019 New revision: 505631 URL: https://svnweb.freebsd.org/changeset/ports/505631 Log: graphics/caffe: respect CXX Replace %%CXX%% with the actual value of ${CXX}, not just clang++. This fixes build on GCC architectures. PR: 238884 Approved by: mat (mentor), portmgr (blanket: ports compliance), eric@camachat.org (maintainer) Differential Revision: https://reviews.freebsd.org/D20807 Changes: head/graphics/caffe/Makefile The fix was not correct. Created attachment 206090 [details]
v2
More sophisticated patch is needed.
A commit references this bug: Author: pkubaj Date: Wed Aug 28 19:23:10 UTC 2019 New revision: 510093 URL: https://svnweb.freebsd.org/changeset/ports/510093 Log: graphics/caffe: Respect CXX Don't use clang, unconditionally, respect CXX to fix build on GCC architectures. PR: 238884 Approved by: eric@camachat.org (maintainer timeout), linimon (mentor) Differential Revision: https://reviews.freebsd.org/D21396 Changes: head/graphics/caffe/Makefile |
Created attachment 205422 [details] patch Replace %%CXX%% with the actual value of ${CXX}, not just clang++. This fixes build on GCC architectures.