Bug 238899

Summary: www/cliqz: files/patch-bug1559213 is unused
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed FIXED    
Severity: Affects Only Me CC: santhosh.raju
Priority: --- Keywords: needs-patch
Version: LatestFlags: santhosh.raju: maintainer-feedback+
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238410

Description Jan Beich freebsd_committer freebsd_triage 2019-06-30 22:18:18 UTC 
www/firefox (via Mk/bsd.gecko.mk) passes --with-system-av1 but www/cliqz does not. Given www/cliqz doesn't pass other --with-system-* or --enable-system-* flags maybe the patch should be removed.
Comment 1 Santhosh Raju 2019-07-01 11:31:27 UTC 
(In reply to Jan Beich from comment #0)

Looking at Cliqz's configuration it seems you are right. I have asked a Cliqz developer to confirm it. 

I agree with you, if there are no switches that make use of the patch it should be removed.

Thank you for pointing this out.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-07-01 12:21:27 UTC 
Open issue cant block a closed issue, add to See Also instead

^Triage: Reporter is committer, assign accordingly
Comment 3 Jan Beich freebsd_committer freebsd_triage 2019-07-01 12:38:48 UTC 
(In reply to Kubilay Kocak from comment #2)
> Open issue cant block a closed issue, add to See Also instead

That's how regressions were tracked[1] on bugzilla.mozilla.org until they've introduced a separate field to avoid ambiguity. See also bug 203179.

[1] https://mozilla.github.io/bug-handling/regressions
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-07-01 15:54:58 UTC 
A commit references this bug:

Author: jbeich
Date: Mon Jul  1 15:54:42 UTC 2019
New revision: 505609
URL: https://svnweb.freebsd.org/changeset/ports/505609

Log:
  www/cliqz: drop patch accidentally copied from www/firefox

  This port doesn't use --with-system-av1, so keeping the patch would
  only introduce unnecessary churn on updates.

  PR:		238899
  Approved by:	Santhosh Raju (maintainer, implicit)

Changes:
  head/www/cliqz/files/patch-bug1559213