Bug 239029

Summary: net/spoofer: fix arc4random_stir #ifdef to build on freebsd 13
Product: Ports & Packages Reporter: mjl
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me Flags: mjl: maintainer-feedback+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
use the arc4random_stir macro mjl: maintainer-approval+

Description mjl 2019-07-07 09:29:28 UTC
Created attachment 205559 [details]
use the arc4random_stir macro

freebsd 13+ doesn't have arc4random_stir.  The spoofer system has configure logic to detect the presence of arc4random_stir but the C++ code currently doesn't use the logic correctly.  This patch should fix the issue.
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-07-07 10:21:05 UTC
I would make minor modification to remove OpenBSD comment since defined(__OpenBSD__) was removed.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-07-07 19:17:18 UTC
A commit references this bug:

Author: sunpoet
Date: Sun Jul  7 19:16:15 UTC 2019
New revision: 506192
URL: https://svnweb.freebsd.org/changeset/ports/506192

Log:
  Fix arc4random_stir on FreeBSD 13+

  PR:		239029
  Submitted by:	Matthew Luckie <mjl@luckie.org.nz> (maintainer)

Changes:
  head/net/spoofer/Makefile
  head/net/spoofer/files/patch-common-util.cc
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-07-07 19:17:40 UTC
Committed. Thanks!