Bug 239070
| Summary: | textproc/py-markdown: Update to 3.3.4 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Alexander Sieg <ports> | ||||||
| Component: | Individual Port(s) | Assignee: | Neel Chauhan <nc> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | FreeBSD, andreas, arved, lwhsu, nc, sunpoet, swills, ygy | ||||||
| Priority: | --- | Flags: | koobs:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| URL: | https://python-markdown.github.io/change_log/ | ||||||||
| See Also: | https://reviews.freebsd.org/D29803 | ||||||||
| Bug Depends on: | 255278, 255281 | ||||||||
| Bug Blocks: | 248886 | ||||||||
| Attachments: |
|
||||||||
3.2 dropped support for Python 2.x: https://python-markdown.github.io/change_log/release-3.2/ This needs additional QA, in particular for dependents/consumers of Markdown, and potentially a markdown2 port (copied from the current version) If updating to 3.2 is too complicated because of python2, maybe updating to 3.1 is possible? A port update of mine depends on markdown > 3.0. (In reply to Tilman Keskinoz from comment #2) Thanks for the heads-up Tilman What port has your markdown > 3.0 dependency? I'll include it during QA (In reply to Kubilay Kocak from comment #3) www/py-pelican needs officially markdown > 3 (but it's not mentioned correctly within the Makefile). To clarify QA requirements: markdown ports consumers need to be audited for version compatibility (and *_DEPENDS <version-spec> correctness), to determine whether markdown2 is necessary/warranted I'd appreciate any assistance, but will otherwise seek to run/complete QA and report here (In reply to Kubilay Kocak from comment #5) I am fairly new to this process, but can you help me and tell me how I can be useful in speed up the QA process? Do one need to go through all packages with markdown dependencies and check manually if they rely on markdown3 or markdown2? What happens if changes need to be done on the port? Do we need to post a patch here, or do we need an own bug report and link them with this issue here? (In reply to Kubilay Kocak from comment #5) I tried to figure out which ports depends on python-markdown and see if they support python-markdown > 3. Here is my result ==== net-mgmt/netbox, OK (see https://github.com/netbox-community/netbox/blob/v2.10.4/requirements.txt) deskutils/calibre, DONT KNOW (no explicit version dependency found, https://github.com/kovidgoyal/calibre) audio/lv2, DONT KNOW (but only for Doxygen functionality) games/wxlauncher, PROBABLY OK (Not mentioned explicitly, but referes to Debian package, which is > 3, https://github.com/scp-fs2open/wxLauncher/blob/release-0.10.0/ReadMe.md) www/py-flask-flatpages, DONT KNOW (no explicit version found, https://github.com/Flask-FlatPages/Flask-FlatPages/blob/v0.6/setup.cfg) www/py-grip, MAYBE, requieres > 2.5.1 (https://github.com/joeyespo/grip/blob/v4.5.2/requirements.txt) www/py-pelican, OK (T#248886) www/py-django-markdownx, DONT KNOW (no explicit version found, https://github.com/neutronX/django-markdownx/blob/v3.0.1/requirements.txt) textproc/py-markdown-math, DONT KNOW (no explicit version found, https://github.com/mitya57/python-markdown-math/tree/0.6) textproc/py-mkdocs -> MAYBE, requires >= 2.3.1, BUT recent version requires >= 3.2.1 (https://github.com/mkdocs/mkdocs/blob/1.1.2/setup.py) textproc/retext, DONT KNOW, no explicit version dependency found, BUT recent version requieres >= 3.0 (https://github.com/retext-project/retext/blob/7.2.0/setup.py) devel/py-cmdtest, DONT KNOW (no explicit version dependency found http://git.liw.fi/cmdtest/tree/setup.py) devel/py-cheetah3, reuquieres >= 2.0.1 < 3.2 (https://github.com/CheetahTemplate3/cheetah3/blob/3.2.6/tox.ini) devel/py-mdv, DONT KNOW (no explicit version dependency found, https://github.com/axiros/terminal_markdown_viewer) net/py-errbot, REQUIRE markdown < 3.0 net/samba413, DONT KNOW net/samba412, DONT KNOW net/samba411, DONT KNOW biology/py-multiqc, MAYBE, enforces < 3.2 for python < 3.6 installs (https://github.com/ewels/MultiQC/blob/v1.9/setup.py) ==== Is this of any use for you? What would be the next steps? Try each of that port with python-markdow > 3? Patch for updating to 3.3.4: https://reviews.freebsd.org/D29803 If we still cannot verify all the ports can live with textproc/py-markdown verion 3, since it's blocking other issues, I suggest we backup version 2 to textproc/py-markdown2 or adding version3 as textproc/py-markdown3. Keeping existing things working is important, but making progress and not blocking new things is also the same important. (In reply to Andreas Bilke from comment #7) For these ports: devel/py-cheetah3 - can easily be patched. Older py-markdown is required mainly for Python 2 support: https://github.com/CheetahTemplate3/cheetah3/commit/35571a00395c4ef937a08ae5a3686700a53bd1d1#diff-ef2cef9f88b4fe09ca3082140e67f5ad34fb65fb6e228f119d3812261ae51449 net/py-errbot - can be updated which supports py-markdown 3.3+: https://github.com/errbotio/errbot/blob/6.1.7/setup.py Therefore, I propose patching devel/py-cheetah3 and updating net/py-errbot Created attachment 224306 [details] Update to 3.3.4 Update to 3.3.4 based on https://reviews.freebsd.org/D29803. All the ports I know of which depended on an earlier py-markdown version have been updated, so it should be safe to commit this port update. Maintainer timeout? I believe koobs@ hasn't responded. I believe all dependent ports got updated to accommodate the new version of py-markdown. Comment on attachment 224306 [details]
Update to 3.3.4
If this passes QA (testsuite and reverse dependents in particular)
Approved by: koobs (maintainer)
MFH: No (backward incompatible)
@Neel Free to land this if it passes QA This has been committed as: d9cf7e20fe3dbf481ec207ef6809f2f2017a8281 https://cgit.freebsd.org/ports/commit/?id=d9cf7e20fe3dbf481ec207ef6809f2f2017a8281 I forgot to mention PR:, sorry. ^Triage: Assign to committer that resolved. @Neel Thank you for landing this, and feel free to self-assign issues you resolve |
Created attachment 205608 [details] patch Update to 3.1.1 portlint OK (looks fine.) poudriere OK (12amd64)