Summary: | textproc/unoconv: SyntaxError: Missing parentheses in call to 'print' with Python 3.x | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Gerasimos Melissaratos <gmelis> |
Component: | Individual Port(s) | Assignee: | Alexey Dokuchaev <danfe> |
Status: | Closed FIXED | ||
Severity: | Affects Some People | CC: | danfe, koalative, ndowens04 |
Priority: | --- | Keywords: | needs-patch, needs-qa |
Version: | Latest | Flags: | koobs:
maintainer-feedback?
(koalative) koobs: merge-quarterly? |
Hardware: | Any | ||
OS: | Any | ||
See Also: | https://github.com/unoconv/unoconv/pull/111 | ||
Attachments: |
@Gerasimos Thank you for the report and patch. Could you update it to be in unified diff format please Created attachment 205652 [details]
patch to make unoconv 0.6_1 run successfully with python3
modified to use unified diff format
Looks like upstream fixed this a while ago in: https://github.com/unoconv/unoconv/pull/111 Upstream (github) is now at 0.8.2 0.7.0 is the latest mentioned on http://dag.wiee.rs/home-made/unoconv/ (homepage) This port has incorrectly not restricted USES=python to only 2.7 (0.6 does not appear to support Python 3) In that case the new version needs to become available in the pkg colection, because it still downloads version 0.6_1. Created attachment 205660 [details]
Makefile for unoconv 0.7
Created attachment 205661 [details]
distinfo for unoconv 0.7
Uploaded Makefile and distfile for version 0.7 of unoconv. Created attachment 205662 [details]
patch for Makefile for unoconv 0.7
diff of Makefile
Created attachment 205663 [details]
patch for distinfo for unoconv 0.7
patch for distinfo
Seems https://github.com/unoconv/unoconv/commit/2f1c63b2df03376b1ac9d3ed9eb4adec621d6b6e should fix this bug, also I am updating this port's version with a CVE patch; Will link to this bug A commit references this bug: Author: danfe Date: Mon Jul 6 14:35:35 UTC 2020 New revision: 541346 URL: https://svnweb.freebsd.org/changeset/ports/541346 Log: - Update to version 0.7 (fixes issue with Python 3.x) - Simplify installation of the documentation files PR: 239106 Submitted by: Gerasimos Melissaratos Changes: head/textproc/unoconv/Makefile head/textproc/unoconv/distinfo Port was updated with ports r541346, thank you. |
Created attachment 205651 [details] patch to make unoconv 0.6_1 run successfully with python3 When starting `/usr/local/bin/unoconv --listener` it crashes with error message: ----- File "/usr/local/share/unoconv/unoconv", line 241 print 'PATH=%s' % os.environ['PATH'] ^ SyntaxError: Missing parentheses in call to 'print'. Did you mean print('PATH=%s' % os.environ['PATH'])? ----- From what I saw it calls python3, but its code still uses python2 functions. The attached patch modifies the code from python2 to use python3 and starts unoconv successfully.