Bug 239172
| Summary: | mail/dovecot imap/pop3 stat-writer issue | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Marek <zillion1> |
| Component: | Individual Port(s) | Assignee: | Larry Rosenman <ler> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | vvd |
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(ler) |
| Version: | Latest | ||
| Hardware: | amd64 | ||
| OS: | Any | ||
|
Description
Marek
2019-07-12 17:54:25 UTC
I'm seeing this too. Looking at it. Thanks for the report. A commit references this bug: Author: ler Date: Fri Jul 12 19:22:10 UTC 2019 New revision: 506487 URL: https://svnweb.freebsd.org/changeset/ports/506487 Log: mail/dovecot: stop spamming the log with EINVAL. PR: 239172 Submitted by: zillion1@o2.pl Obtained from: dovecot mailing list. Changes: head/mail/dovecot/Makefile head/mail/dovecot/files/patch-src_lib_ostream-file.c Fix committed. Confirmed, spamming logs has gone :) Still spam in log: tail -f /var/log/dovecot/dovecot.log Jul 15 19:51:24 imap-login: Error: file_ostream.net_set_tcp_nodelay(, TRUE) failed: Connection reset by peer Jul 15 19:52:39 imap-login: Error: file_ostream.net_set_tcp_nodelay(, TRUE) failed: Connection reset by peer Jul 15 19:58:43 imap-login: Error: file_ostream.net_set_tcp_nodelay(, TRUE) failed: Connection reset by peer Jul 15 20:02:23 imap-login: Error: file_ostream.net_set_tcp_nodelay(, TRUE) failed: Connection reset by peer Jul 15 20:03:57 imap-login: Error: file_ostream.net_set_tcp_nodelay(, TRUE) failed: Connection reset by peer Jul 15 20:04:44 imap-login: Error: file_ostream.net_set_tcp_nodelay(, TRUE) failed: Connection reset by peer Jul 15 20:04:44 imap-login: Error: file_ostream.net_set_tcp_nodelay(, TRUE) failed: Connection reset by peer Jul 15 20:05:24 imap-login: Error: file_ostream.net_set_tcp_nodelay(, TRUE) failed: Connection reset by peer Jul 15 20:06:39 imap-login: Error: file_ostream.net_set_tcp_nodelay(, TRUE) failed: Connection reset by peer Jul 15 20:07:27 imap-login: Error: file_ostream.net_set_tcp_nodelay(, TRUE) failed: Connection reset by peer Jul 15 20:08:28 imap-login: Error: file_ostream.net_set_tcp_nodelay(, TRUE) failed: Connection reset by peer Jul 15 20:09:31 imap-login: Error: file_ostream.net_set_tcp_nodelay(, TRUE) failed: Connection reset by peer Jul 15 20:12:23 imap-login: Error: file_ostream.net_set_tcp_nodelay(, TRUE) failed: Connection reset by peer Jul 15 20:24:11 imap-login: Error: file_ostream.net_set_tcp_nodelay(, TRUE) failed: Connection reset by peer Name : dovecot Version : 2.3.7_1 Installed on : Sat Jul 13 19:12:08 2019 MSK Origin : mail/dovecot Architecture : FreeBSD:10:amd64 Prefix : /usr/local Categories : ipv6 mail Licenses : MIT, LGPL21 Maintainer : ler@FreeBSD.org WWW : http://www.dovecot.org/ Comment : Secure, fast and powerful IMAP and POP3 server Options : CDB : off DOCS : on EXAMPLES : on GSSAPI_BASE : off GSSAPI_HEIMDAL : off GSSAPI_MIT : off GSSAPI_NONE : on ICU : on LDAP : on LIBSODIUM : off LIBWRAP : off LUA : off LUCENE : off LZ4 : on MYSQL : on PGSQL : off SOLR : off SQLITE : off TEXTCAT : off VPOPMAIL : off that looks like a firewall issue.... Probably it's incorrect disconnected clients. the latest port (2.3.7_3) doesn't log these any more. from an upstream patch. (In reply to Larry Rosenman from comment #8) Thanks, they has gone now. A commit references this bug: Author: ler Date: Thu Aug 29 14:47:26 UTC 2019 New revision: 510165 URL: https://svnweb.freebsd.org/changeset/ports/510165 Log: MFH: r506460 r506487 r506821 r506824 r507181 r507215 r510075 mail/dovecot, mail/dovecot-pigeonhole: Update to 2.3.7 and 0.5.7 respectively. dovecot changelog: * fts-solr: Removed break-imap-search parameter + Added more events for the new statistics, see https://doc.dovecot.org/admin_manual/list_of_events/ + mail-lua: Add IMAP metadata accessors, see https://doc.dovecot.org/admin_manual/lua/ + Add event exporters that allow exporting raw events to log files and external systems, see https://doc.dovecot.org/configuration_manual/event_export/ + SNIPPET is now PREVIEW and size has been increased to 200 characters. + Add body option to fts_enforced. This triggers building FTS index only on body search, and an error using FTS index fails the search rather than reads through all the mails. - Submission/LMTP: Fixed crash when domain argument is invalid in a second EHLO/LHLO command. - Copying/moving mails using Maildir format loses IMAP keywords in the destination if the mail also has no system flags. - mail_attachment_detection_options=add-flags-on-save caused email body to be unnecessarily opened when FETCHing mail headers that were already cached. - mail attachment detection keywords not saved with maildir. - dovecot.index.cache may have grown excessively large in some situations. This happened especially when using autoexpunging with lazy_expunge folders. Also with mdbox format in general the cache file wasn't recreated as often as it should have. - Autoexpunged mails weren't immediately deleted from the disk. Instead, the deletion from disk happened the next time the folder was opened. This could have caused unnecessary delays if the opening was done by an interactive IMAP session. - Dovecot's TCP connections sometimes add extra 40ms latency due to not enabling TCP_NODELAY. HTTP and SMTP/LMTP connections weren't affected, but everything else was. This delay wasn't always visible - only in some situations with some message/packet sizes. - imapc: Fix various crash conditions - Dovecot builds were not always reproducible. - login-proxy: With shutdown_clients=no after config reload the existing connections could no longer be listed or kicked with doveadm. - "doveadm proxy kick" with -f parameter caused a crash in some situations. - Auth policy can cause segmentation fault crash during auth process shutdown if all auth requests have not been finished. - Fix various minor bugs leading into incorrect behaviour in mailbox list index handling. These rarely caused noticeable problems. - LDAP auth: Iteration accesses freed memory, possibly crashing auth-worker - local_name { .. } filter in dovecot.conf does not correctly support multiple names and wildcards were matched incorrectly. - replicator: dsync assert-crashes if it can't connect to remote TCP server. - config: Memory leak in config process when ssl_dh setting wasn't set and there was no ssl-parameters.dat file. This caused config process to die once in a while with "out of memory". pigeonhole changelog: + vacation: Made the subject for the automatic response message produced by the Sieve vacation action configurable. Both the default subject (if the script defines none) and the subject template (e.g. used to add a subject prefix) can be configured. - dsync: dsync-replication does not synchronize Sieve scripts. - imap_sieve_filter: Reduce FILTER=SIEVE verbosity over IMAP connection. - testsuite: Pigeonhole testsuite segfaulted if it was compiled with GCC 9 mail/dovecot: stop spamming the log with EINVAL. PR: 239172 Submitted by: zillion1@o2.pl Obtained from: dovecot mailing list. mail/dovecot: stop whining about TCP_NODELAY errors. [PATCH] lib: ostream-file: Don't log any errors when setting TCP_NODELAY It's likely never useful to log the error, and it seems more and more unexpected errors just keep popping up. Obtained from: upstream git. mail/dovecot: One should actually TEST their patches. Fix previous commit. Pointy Hat To: ler mail/dovecot: [PATCH] lib-storage: Namespace prefix shouldn't be included in all mailbox name validity checks Obtained from: upstream github. mail/dovecot, mail/dovecot-pigeonhole: upgrade to 2.3.7.1 and 0.5.7.1 respectively. These releases fix the reported regressions in v2.3.7 & v0.5.7. Dovecot core: - Fix TCP_NODELAY errors being logged on non-Linux OSes - lmtp proxy: Fix assert-crash when client uses BODY=8BITMIME - Remove wrongly added checks in namespace prefix checking Pigeonhole: - dsync: Sieve script syncing failed if mailbox attributes weren't enabled. mail/dovecot,mail/dovecot-pigeonhole: fix CVE-2019-11500 Changes ------- * CVE-2019-11500: IMAP protocol parser does not properly handle NUL byte when scanning data in quoted strings, leading to out of bounds heap memory writes. Found by Nick Roessler and Rafi Rubin. Security: CVE-2019-11500 PR: 241074 Approved by: ports-secteam (delphij, joneum) Changes: _U branches/2019Q3/ branches/2019Q3/mail/dovecot/Makefile branches/2019Q3/mail/dovecot/distinfo branches/2019Q3/mail/dovecot/pkg-plist branches/2019Q3/mail/dovecot-pigeonhole/Makefile branches/2019Q3/mail/dovecot-pigeonhole/distinfo |
