Bug 239195

Summary:	astro/marble: GPS option slightly broken
Product:	Ports & Packages	Reporter:	Tobias Kortkamp <tobik>
Component:	Individual Port(s)	Assignee:	freebsd-kde (group) <kde>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	kde, tcberner
Priority:	---	Keywords:	needs-patch
Version:	Latest	Flags:	tcberner: maintainer-feedback+
Hardware:	Any
OS:	Any

Description Tobias Kortkamp freebsd_committer

2019-07-14 04:30:17 UTC

There is no such thing as an GPS_CMAKE_BOOL_ON options helper (should have been
GPS_CMAKE_BOOL) so at the moment the GPS option solely relies on the presence
or absence of libgps.so to turn on/off libgps support.

I do not see any references to WITH_libgps in CMakeLists.txt or I
would have just fixed it.  Maybe it should use
CMAKE_DISABLE_FIND_PACKAGE_libgps or similar instead like the
WEBENGINE option.

Comment 1 Tobias C. Berner freebsd_committer

2019-07-14 07:27:21 UTC

Fixed. Thanks.

Comment 2 commit-hook freebsd_committer

2019-07-14 07:27:37 UTC

A commit references this bug:

Author: tcberner
Date: Sun Jul 14 07:27:06 UTC 2019
New revision: 506608
URL: https://svnweb.freebsd.org/changeset/ports/506608

Log:
  astro/marble: fix GPS option

  - Fix cmake toggle to disable GPS dependency

  PR:		239195
  Reported by:	tobik

Changes:
  head/astro/marble/Makefile