Bug 239203

Summary: www/otter-browser: Update to 1.0.81
Product: Ports & Packages Reporter: George <gosha-necr>
Component: Individual Port(s)Assignee: kde
Status: Closed FIXED    
Severity: Affects Many People CC: adridg, gosha-necr, kai, kde, tcberner
Priority: --- Flags: tcberner: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
port diff
none
Latest snapshot none

Description George 2019-07-14 16:06:03 UTC
Created attachment 205767 [details]
port diff

Updating to latest snapshot.
Comment 1 Tobias C. Berner freebsd_committer 2019-07-21 14:32:26 UTC
Why the portrevision?

Mfg Tobias
Comment 2 George 2019-07-29 11:43:15 UTC
(In reply to Tobias C. Berner from comment #1)
Because in one internal version (1.0.81 now) new snapshots will be incremented revisions in port. It is not correct?
Comment 3 Adriaan de Groot freebsd_committer 2019-07-29 13:15:48 UTC
What tcberner@ means is "why do you leave PORTREVISION set to 1 in the Makefile, instead of taking it out completely?"

Normally, when a DISTVERSION or PORTVERSION is updated to a new release, PORTREVISION is reset to zero -- there isn't a revision of the port with that version yet. And we leave out the zero. Then if the port is changed, it gets PORTREVISION=1 and so-on.

Also, we don't often update software to unreleased snapshots; there's no source tag for this one either, so what makes you think this is 1.0.81 (rather than, say, 1.0.2)? I can't see anything in the weekly otter notes to make me think that there's a release imminent.
Comment 4 George 2019-07-29 18:20:22 UTC
(In reply to Adriaan de Groot from comment #3)
Ok, I understand about portrevision.

About dev version 1.0.81, it defines here:
packaging/otter-browser.iss:
#define MyAppVersion "1.0.81-dev"
Comment 5 George 2019-07-29 18:38:42 UTC
Created attachment 206143 [details]
Latest snapshot

1. Update to latest snapshot of 1.0.81-dev version (0065e90)
2. Remove PORTREVISION
3. Expand %%DATADIR%% in pkg-plist
Comment 6 Tobias C. Berner freebsd_committer 2019-08-04 18:18:28 UTC
Hi George

Why did you pick that given ref 0065e90?
Is there a bug fix or a feature that is not present in the official release that you require?

mfg Tobias
Comment 7 George 2019-08-13 06:11:35 UTC
(In reply to Tobias C. Berner from comment #6)
Since otter-browser are in development state, I mean that it's regular actual builds are needed for those who use that browser.
And since it in very early stage, every new build has fixes and improvements.
Comment 8 Adriaan de Groot freebsd_committer 2019-08-19 08:51:06 UTC
There's a bunch of QtWebKit (now that 212-alpha3 is out) and Qt 5.13 fixes in the otter tree, I think it would be worthwhile to chase some updates.
Comment 9 commit-hook freebsd_committer 2019-10-12 12:57:12 UTC
A commit references this bug:

Author: adridg
Date: Sat Oct 12 12:56:42 UTC 2019
New revision: 514333
URL: https://svnweb.freebsd.org/changeset/ports/514333

Log:
  Update otter-browser to a snapshot.

  The last official release was 1.0.01 in january 2019, way too long
  ago for a web browser. Many Linux distro's also offer weekly
  snapshots of this browser (often calling it 1.0.81). Instead,
  bump to a different fake release number; I'm concerned that
  1.0.81 might be too high.

  Fixes in the tree relate to both QtWebKit and QtWebEngine compatibility,
  as well as Qt 5.13 compatibility.

  Initial patch by George; I bumped to a different (newer) revision in week 300.

  PR:		239203
  Reported by:	George

Changes:
  head/www/otter-browser/Makefile
  head/www/otter-browser/distinfo