Bug 239342

Summary: sysutils/openzfs-kmod build failure on -CURRENT
Product: Ports & Packages Reporter: Graham Perrin <grahamperrin>
Component: Individual Port(s)Assignee: Kris Moore <kmoore>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (kmoore)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Full log none

Description Graham Perrin freebsd_committer freebsd_triage 2019-07-20 13:19:35 UTC 
Created attachment 205932 [details]
Full log

grahamperrin@momh167-gjp4-8570p:~ % date ; uname -v 
Sat 20 Jul 2019 14:14:14 BST
FreeBSD 13.0-CURRENT r350027 GENERIC 
grahamperrin@momh167-gjp4-8570p:~ % cat /usr/local/poudriere/data/logs/bulk/head-default/2019-07-20_14h06m01s/logs/openzfs-kmod-2019070800.log 
=>> Building sysutils/openzfs-kmod
build started at Sat Jul 20 14:06:14 BST 2019
port directory: /usr/ports/sysutils/openzfs-kmod
package name: openzfs-kmod-2019070800
building for: FreeBSD head-default-job-01 13.0-CURRENT FreeBSD 13.0-CURRENT 1300036 amd64
maintained by: kmoore@FreeBSD.org
Makefile ident:      $FreeBSD: head/sysutils/openzfs-kmod/Makefile 506233 2019-07-08 17:25:44Z kmoore $
Poudriere version: 3.3.2_1
Host OSVERSION: 1300036
Jail OSVERSION: 1300036
Job Id: 01

…

ctfconvert -L VERSION -g zfs_vfsops.o
cc  -O2 -pipe  -std=gnu99 -fstack-protector-strong -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member   -Qunused-arguments -Wno-missing-prototypes  -Wno-strict-prototypes -Wno-pointer-arith   -include /wrkdirs/usr/ports/sysutils/openzfs-kmod/work/ZoF-d63de7c/include/os/freebsd/spl/sys/ccompile.h -D__KERNEL__ -DFREEBSD_NAMECACHE -DBUILDING_ZFS -D__BSD_VISIBLE=1 -DHAVE_UIO_ZEROCOPY -DHAVE_KSID -DWITHOUT_NETDUMP -D_SYS_VMEM_H_ -D_MACHINE_ENDIAN_H_ -DKDTRACE_HOOKS -DHAVE_AVX2 -DHAVE_AVX -D__x86_64 -DHAVE_SSE2 -DHAVE_AVX512F -DNDEBUG -DBITS_PER_LONG=64 -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc  -I/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/ZoF-d63de7c/include -I/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/ZoF-d63de7c/include/spl -I/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/ZoF-d63de7c/include/os/freebsd -I/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/ZoF-d63de7c/include/os/freebsd/spl -I/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/ZoF-d63de7c/include/os/freebsd/zfs -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include     -MD  -MF.depend.zfs_vnops.o -MTzfs_vnops.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member  -Qunused-arguments -mno-aes -mno-avx -Wno-missing-prototypes  -Wno-strict-prototypes -Wno-pointer-arith -std=iso9899:1999 -c /wrkdirs/usr/ports/sysutils/openzfs-kmod/work/ZoF-d63de7c/module/os/freebsd/zfs/zfs_vnops.c -o zfs_vnops.o
/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/ZoF-d63de7c/module/os/freebsd/zfs/zfs_vnops.c:446:4: error: implicit declaration of function 'vm_page_hold' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                        vm_page_hold(pp);
                        ^
/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/ZoF-d63de7c/module/os/freebsd/zfs/zfs_vnops.c:446:4: note: did you mean 'page_hold'?
/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/ZoF-d63de7c/module/os/freebsd/zfs/zfs_vnops.c:419:1: note: 'page_hold' declared here
page_hold(vnode_t *vp, int64_t start)
^
/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/ZoF-d63de7c/module/os/freebsd/zfs/zfs_vnops.c:461:2: error: implicit declaration of function 'vm_page_unhold' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        vm_page_unhold(pp);
        ^
/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/ZoF-d63de7c/module/os/freebsd/zfs/zfs_vnops.c:461:2: note: did you mean 'page_unhold'?
/wrkdirs/usr/ports/sysutils/openzfs-kmod/work/ZoF-d63de7c/module/os/freebsd/zfs/zfs_vnops.c:457:1: note: 'page_unhold' declared here
page_unhold(vm_page_t pp)
^
2 errors generated.
*** Error code 1

Stop.
make[1]: stopped in /wrkdirs/usr/ports/sysutils/openzfs-kmod/work/ZoF-d63de7c/module
*** Error code 1

Stop.
make: stopped in /usr/ports/sysutils/openzfs-kmod
=>> Cleaning up wrkdir
===>  Cleaning for openzfs-kmod-2019070800
build of sysutils/openzfs-kmod | openzfs-kmod-2019070800 ended at Sat Jul 20 14:06:45 BST 2019
build time: 00:00:31
!!! build failure encountered !!!
grahamperrin@momh167-gjp4-8570p:~ %
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-07-20 17:20:23 UTC 
A commit references this bug:

Author: kmoore
Date: Sat Jul 20 17:19:42 UTC 2019
New revision: 507006
URL: https://svnweb.freebsd.org/changeset/ports/507006

Log:
  - Update to 2019072000
  - Unbreak on CURRENT

  Includes the new Log Spacemap functionality:
  https://github.com/zfsonlinux/zfs/pull/8442

  PR: 239342
  Sponsored by: iXsystems

Changes:
  head/sysutils/openzfs/Makefile
  head/sysutils/openzfs/distinfo
  head/sysutils/openzfs/pkg-plist
  head/sysutils/openzfs-kmod/Makefile
  head/sysutils/openzfs-kmod/distinfo
Comment 2 Graham Perrin freebsd_committer freebsd_triage 2019-07-26 06:06:27 UTC 
Fix confirmed 👍

Thanks