Bug 239399

Summary:	Flakey test case: sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger
Product:	Base System	Reporter:	Li-Wen Hsu <lwhsu>
Component:	tests	Assignee:	Li-Wen Hsu <lwhsu>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	emaste, jhb
Priority:	---
Version:	CURRENT
Hardware:	Any
OS:	Any
See Also:	https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239425 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239397 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239292 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240510

Description Li-Wen Hsu freebsd_committer

2019-07-23 09:36:25 UTC

https://ci.freebsd.org/job/FreeBSD-head-amd64-test/11771/testReport/junit/sys.kern/ptrace_test/ptrace__parent_sees_exit_after_child_debugger/

Error Message

/usr/src/tests/sys/kern/ptrace_test.c:333: WEXITSTATUS(status) == 0 not met

Standard Error

Test case metadata
------------------

allowed_architectures is empty
allowed_platforms is empty
description is empty
has_cleanup = false
is_exclusive = false
required_configs is empty
required_disk_space = 0
required_files is empty
required_memory = 0
required_programs is empty
required_user is empty
timeout = 300

Timing information
------------------

Start time: 2019-07-05T21:37:06.725189Z
End time:   2019-07-05T21:37:06.736977Z
Duration:   0.012s

Original stderr
---------------

/usr/src/tests/sys/kern/ptrace_test.c:269: read(cpipe[1], &c, sizeof(c)) == sizeof(c) not met
/usr/src/tests/sys/kern/ptrace_test.c:300: WEXITSTATUS(status) == 1 not met

Comment 1 commit-hook freebsd_committer

2019-07-23 09:39:39 UTC

A commit references this bug:

Author: lwhsu
Date: Tue Jul 23 09:39:27 UTC 2019
New revision: 350239
URL: https://svnweb.freebsd.org/changeset/base/350239

Log:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger

  PR:		239399
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/tests/sys/kern/ptrace_test.c

Comment 2 commit-hook freebsd_committer

2019-10-25 21:52:11 UTC

A commit references this bug:

Author: lwhsu
Date: Fri Oct 25 21:52:03 UTC 2019
New revision: 354105
URL: https://svnweb.freebsd.org/changeset/base/354105

Log:
  MFC r350211, r350220, r350235, r350238-r350239, r350295, r350512, r350700, r352219

  r350211:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__follow_fork_child_detached_unrelated_debugger

  PR:		239292
  Sponsored by:	The FreeBSD Foundation

  r350220:
  Fix URL.

  Sponsored by:	The FreeBSD Foundation

  r350235:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__PT_KILL_competing_stop

  PR:		220841
  Sponsored by:	The FreeBSD Foundation

  r350238:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__follow_fork_both_attached_unrelated_debugger

  PR:		239397
  Sponsored by:	The FreeBSD Foundation

  r350239:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger

  PR:		239399
  Sponsored by:	The FreeBSD Foundation

  r350295:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__follow_fork_parent_detached_unrelated_debugger

  PR:		239425
  Sponsored by:	The FreeBSD Foundation

  r350512:
  Only skip test cases sometimes failing in CI when they are running in CI

  Suggested by:	jhb
  Sponsored by:	The FreeBSD Foundation

  r350700:
  Get configuration variable with default value for not breaking default setting

  Reported by:	markj
  Sponsored by:	The FreeBSD Foundation

  r352219:
  Temporarily skip flakey test case sys.kern.ptrace_test.ptrace__getppid

  PR:		240510
  Sponsored by:	The FreeBSD Foundation

Changes:
_U  stable/12/
  stable/12/tests/sys/kern/ptrace_test.c

Comment 3 commit-hook freebsd_committer

2019-10-28 13:07:06 UTC

A commit references this bug:

Author: lwhsu
Date: Mon Oct 28 13:06:02 UTC 2019
New revision: 354134
URL: https://svnweb.freebsd.org/changeset/base/354134

Log:
  MFC r350211, r350220, r350235, r350238-r350239, r350295, r350512, r350700, r352219

  r350211:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__follow_fork_child_detached_unrelated_debugger

  PR:		239292
  Sponsored by:	The FreeBSD Foundation

  r350220:
  Fix URL.

  Sponsored by:	The FreeBSD Foundation

  r350235:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__PT_KILL_competing_stop

  PR:		220841
  Sponsored by:	The FreeBSD Foundation

  r350238:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__follow_fork_both_attached_unrelated_debugger

  PR:		239397
  Sponsored by:	The FreeBSD Foundation

  r350239:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger

  PR:		239399
  Sponsored by:	The FreeBSD Foundation

  r350295:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__follow_fork_parent_detached_unrelated_debugger

  PR:		239425
  Sponsored by:	The FreeBSD Foundation

  r350512:
  Only skip test cases sometimes failing in CI when they are running in CI

  Suggested by:	jhb
  Sponsored by:	The FreeBSD Foundation

  r350700:
  Get configuration variable with default value for not breaking default setting

  Reported by:	markj
  Sponsored by:	The FreeBSD Foundation

  r352219:
  Temporarily skip flakey test case sys.kern.ptrace_test.ptrace__getppid

  PR:		240510
  Sponsored by:	The FreeBSD Foundation

Changes:
_U  stable/11/
  stable/11/tests/sys/kern/ptrace_test.c

Comment 4 Ed Maste freebsd_committer

2024-11-25 13:44:13 UTC

The referenced commit is not a fix - it is only skipping the flaky test. The skips were removed by the commit referenced below (it seems this PR was unintentionally omitted).

Author:     Alex Richardson <arichardson@FreeBSD.org>
AuthorDate: Mon Mar 1 18:51:02 2021 +0000
Commit:     Alex Richardson <arichardson@FreeBSD.org>
CommitDate: Mon Mar 1 19:56:05 2021 +0000

    Remove atf_tc_skip calls from ptrace_test

    I've run these tests many times in a loop on multiple architectures and
    it works reliably for me, maybe it's time to retire these skips?
    This also adds an additional waitpid to one of the tests to avoid
    a potential race condition (suggested by markj@).
        
    PR:             239397, 244056, 239425, 240510, 220841, 243605
    Reviewed By:    markj
    Differential Revision: https://reviews.freebsd.org/D28888