Bug 239437

Summary: audio/mixxx: fix build on non-x86
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Jose Alonso Cardenas Marquez <acm>
Status: Closed FIXED    
Severity: Affects Only Me CC: acm
Priority: --- Flags: bugzilla: maintainer-feedback? (acm)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch pkubaj: maintainer-approval? (acm)

Description Piotr Kubaj freebsd_committer freebsd_triage 2019-07-25 07:22:08 UTC
Created attachment 206048 [details]
patch

Don't optimize for native. It optimizes for the compiling CPU which may break runtime on the user CPU.

It also breaks compilation e.g. on powerpc64, -march=native is not available there. Bump PORTREVISION because of package change.

Also include sys/types.h in plugins/soundsourcem4a/soundsourcem4a.h for uint (needed by GCC).
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-08-02 14:23:26 UTC
This builds for me on both amd64 and powerpc64.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-08-13 01:32:59 UTC
A commit references this bug:

Author: acm
Date: Tue Aug 13 01:32:49 UTC 2019
New revision: 508806
URL: https://svnweb.freebsd.org/changeset/ports/508806

Log:
  - Fix build on non-x86
  - Fix build on powerpc64

  PR:		239437
  Submitted by:	pkubaj

Changes:
  head/audio/mixxx/Makefile
  head/audio/mixxx/files/patch-plugins_soundsourcem4a_soundsourcem4a.h