Bug 239482
| Summary: | science/nest: fix build with GCC-based architectures | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||||
| Component: | Individual Port(s) | Assignee: | Piotr Kubaj <pkubaj> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | yuri | ||||||
| Priority: | --- | Flags: | yuri:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Hi Piotr,
The right way is for the missing "#include <sys/time.h>" to be submitted as PR to their GitHub account. Then this PR patch should be back-ported with:
> PATCH_SITES= https://github.com/${GH_PROJECT}/${PORTNAME}/commit/
> PATCHFILES= {commit-hash}.patch:-p1
Yuri
This builds for me on both amd64 and powerpc64. Piotr, The correct way of doing this is to submit the pull request for the GitHub project https://github.com/nest/nest-simulator because '#include <sys/time.h>' is just missing there. Only by accident it manifests only on gcc systems. Please submit a pull request and update the patch using PATCH* statements. Thanks! Yuri (In reply to Yuri Victorovich from comment #4) Yes, I submitted a pull request. (In reply to Piotr Kubaj from comment #5) Great! Update the patch then. Yuri Created attachment 207648 [details]
v2
A commit references this bug: Author: pkubaj Date: Sat Sep 21 16:34:48 UTC 2019 New revision: 512523 URL: https://svnweb.freebsd.org/changeset/ports/512523 Log: science/nest: fix build with GCC-based architectures nestkernel/simulation_manager.h needs include sys/time.h for timeval struct when compiling with GCC. PR: 239482 Approved by: yuri (maintainer), linimon (mentor) Changes: head/science/nest/Makefile head/science/nest/distinfo |
Created attachment 206106 [details] patch nestkernel/simulation_manager.h needs include sys/time.h for timeval struct when compiling with GCC.