Bug 239553

Summary: science/InsightToolkit: fix build with GCC-based architectures
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Ben Woods <woodsb02>
Status: Closed FIXED    
Severity: Affects Only Me CC: woodsb02
Priority: --- Flags: woodsb02: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch
none
v2 pkubaj: maintainer-approval? (woodsb02)

Description Piotr Kubaj freebsd_committer 2019-07-31 09:28:31 UTC
Created attachment 206173 [details]
patch

After the switch to GCC9, it's necessary to expand the ifdef.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-08-02 16:34:07 UTC
This builds for me on both amd64 and powerpc64.
Comment 2 Ben Woods freebsd_committer 2019-08-04 03:17:23 UTC
Hi pkubaj@ and linimon@,
Thanks for the bug report, and for the patch (always love it when bugs come with patches).

However, as of today I suspect this could be "overcome by events". I just updated the port science/InsightToolkit to version 5.0.1 and this has removed the local patch that is being updated here entirely.
https://svnweb.freebsd.org/changeset/ports/508047

Given that the 2019Q3 ports quarterly branch still uses GCC=8 by default, this patch was only necessary in the port head branch.
https://svnweb.freebsd.org/ports/branches/2019Q3/Mk/bsd.default-versions.mk?view=markup

If the new version of science/InsightToolkit version 5.0.1  does not need this patch, then I think we can close this bug (can you please confirm?).
Comment 3 Piotr Kubaj freebsd_committer 2019-08-24 12:47:00 UTC
Created attachment 206846 [details]
v2

Now plist changes when compiler is GCC.
Comment 4 Piotr Kubaj freebsd_committer 2019-09-04 09:31:17 UTC
*** Bug 239765 has been marked as a duplicate of this bug. ***
Comment 5 Piotr Kubaj freebsd_committer 2019-09-30 14:16:57 UTC
Already committed.