Bug 239622
| Summary: | x11-themes/qtcurve: fix build with GCC-based architectures | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Piotr Kubaj <pkubaj> | ||||||
| Component: | Individual Port(s) | Assignee: | Jason E. Hale <jhale> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | jhale, linimon | ||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(jhale) |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
This fails to patch for me: ===> Applying distribution patches for qtcurve-1.9.0.r1_6 patch: **** can't cd to /ports/default/x11-themes/qtcurve/work/qtcurve-1.9.0-rc1: No such file or directory *** Error code 2 (In reply to Mark Linimon from comment #1) It builds here https://talos.anongoth.pl/data/powerpc64-default/latest-per-pkg/gtk2-qtcurve-theme-1.9.0.r1.log Created attachment 206930 [details]
v2
It seems like that fix only worked for the slave ports. Move the patch definition so that it's only for those.
A commit references this bug: Author: pkubaj Date: Sun Oct 13 00:07:45 UTC 2019 New revision: 514360 URL: https://svnweb.freebsd.org/changeset/ports/514360 Log: x11-themes/qtcurve: fix build with GCC-based architectures GCC9 requires upstream fix because of: /wrkdirs/usr/ports/x11-themes/qtcurve-gtk2/work/qtcurve-a1ec5f8/.cmake_utils_base/cmake_c_macros/include_fix/qtcurve-utils/gtkprops.h:80:24: error: a reinterpret_cast is not a constant expression 80 | return (GObject*)qtcContainerOf(p, Props, name)->m_w; \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /wrkdirs/usr/ports/x11-themes/qtcurve-gtk2/work/qtcurve-a1ec5f8/.cmake_utils_base/cmake_c_macros/include_fix/qtcurve-utils/gtkprops.h:161:9: note: in expansion of macro 'DEF_WIDGET_SIG_CONN_PROPS' PR: 239622 Approved by: jhale (maintainer timeout), tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D21993 Changes: head/x11-themes/qtcurve/Makefile head/x11-themes/qtcurve/distinfo |
Created attachment 206244 [details] patch GCC9 requires upstream fix because of: /wrkdirs/usr/ports/x11-themes/qtcurve-gtk2/work/qtcurve-a1ec5f8/.cmake_utils_base/cmake_c_macros/include_fix/qtcurve-utils/gtkprops.h:80:24: error: a reinterpret_cast is not a constant expression 80 | return (GObject*)qtcContainerOf(p, Props, name)->m_w; \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /wrkdirs/usr/ports/x11-themes/qtcurve-gtk2/work/qtcurve-a1ec5f8/.cmake_utils_base/cmake_c_macros/include_fix/qtcurve-utils/gtkprops.h:161:9: note: in expansion of macro 'DEF_WIDGET_SIG_CONN_PROPS'