Summary: | devel/valgrind fails to build after r348628 | ||||||
---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | Yuichiro NAITO <naito.yuichiro> | ||||
Component: | bin | Assignee: | Ed Maste <emaste> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | dev, dinoex, doctorwhoguy, lab+bsd, lantw44, mandree, ml, paulf, pjfloyd, russo, uqs, zeising | ||||
Priority: | --- | Keywords: | regression | ||||
Version: | CURRENT | Flags: | pjfloyd:
maintainer-feedback?
|
||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 245997 | ||||||
Attachments: |
|
Description
Yuichiro NAITO
2019-08-06 05:29:19 UTC
Assign to committer of r348628. I opened new differential on https://reviews.freebsd.org/D21472. Please check and see it. A commit references this bug: Author: emaste Date: Fri Sep 20 09:04:52 UTC 2019 New revision: 352551 URL: https://svnweb.freebsd.org/changeset/base/352551 Log: elf_common: add ELF note names r348628 added a definition of NT_GNU_BUILD_ID. Some software (Valgrind) also expects a #define for the note name (ELF_NOTE_GNU) in the case that NT_GNU_BUILD_ID is defined. PR: 239669 Reported by: Yuichiro NAITO Sponsored by: The FreeBSD Foundation Event: EuroBSDCon FreeBSD DevSummit 2019 Changes: head/sys/sys/elf_common.h A commit references this bug: Author: emaste Date: Thu Sep 26 16:39:33 UTC 2019 New revision: 352760 URL: https://svnweb.freebsd.org/changeset/base/352760 Log: MFC r352551: elf_common: add ELF note names r348628 added a definition of NT_GNU_BUILD_ID. Some software (Valgrind) also expects a #define for the note name (ELF_NOTE_GNU) in the case that NT_GNU_BUILD_ID is defined. PR: 239669 Sponsored by: The FreeBSD Foundation Changes: _U stable/12/ stable/12/sys/sys/elf_common.h FYI, this one bites me on 12.1-RC1 - are these changes supposed to land in 12.1-RELEASE, or is it too late? I encountered this error on 12.1-RELEASE-p1, so it definitely affects the release. I just encountered this on my 11.3-STABLE system, after the valgrind port got updated yesterday. Apparently 11.3 got the NT_GNU_BUILD_ID in sys/elf_common.h, too, but I never detected this problem because I had valgrind installed before I updated from 11.2 to 11.3, and the port hadn't needed to be recompiled until today. workaround on 12.1-RELEASE-p2 cat /usr/ports/devel/valgrind/Makefile.local CFLAGS+= -DELF_NOTE_GNU=\\\"GNU\\\" This still affects 12.1-RELEASE-p2 builds in poudriere. Created attachment 213563 [details]
Fix build error
This should sort out the build error, and in the future should ELF_NOTE_GNU become defined again then it will do nothing.
In a contributed diff, I've added the update recommended by Paul Floyd to the patch file for vki-freebsd.h under the devel/valgrind port. The patch for the patch is incorporated into a diff/changeset for devel/valgrind, sysutils/dtc, emulator/qemu and emulators/qemu-devel submitted to FreeBSD bugzilla, this morning available: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245997 This patch is actually obsolete, yes? Both devel/valgrind and devel/valgrind-devel build for me on 12.1-STABLE r364374 (though devel/valgrind-devel has been much advanced from the "stable" port) The patch is certainly not needed for devel/valgrind-devel. I haven't tried compiling the old devel/valgrind code for a while. I'll check and update soon. I still get the same build failure for devel/valgrind with 12.1-RELEASE-p9. (In reply to Paul Floyd from comment #14) This item can now be closed as we've now switched to an updated Valgrind codebase. |