Bug 239671
| Summary: | audio/musicpd: Unconditionally enable syslog support | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Bertrand Petit <bsdpr> | ||||
| Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | bsdpr | ||||
| Priority: | --- | Keywords: | easy, needs-qa | ||||
| Version: | Latest | Flags: | riggs:
maintainer-feedback+
riggs: merge-quarterly+ |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
How about a SYSLOG option enabled by default (OPTIONS_DEFAULT), which gets us what we want for packages/ports in the default state, while allowing/allowing user choice? (In reply to Kubilay Kocak from comment #1) As I understand the evolution of mpd, syslog support became optional and disabled by default when the daemon gained systemd support. Since we are spared from systemd, and since syslog support does not require the presence of a non-base library, I see no gain in making logging optional. If you really want to make it optional, then the text of the sample configuration file would require a modification to mention this optionality. (I met mpd error messages about the "syslog" configuration with stupor and incomprehension when considering that the sample file explicitly mentions that the "syslog" value is acceptable.) A commit references this bug: Author: riggs Date: Wed Aug 7 16:20:35 UTC 2019 New revision: 508317 URL: https://svnweb.freebsd.org/changeset/ports/508317 Log: Enable support for logging through syslog, bump PORTREVISION PR: 239671 Submitted by: bsdpr@phoe.frmug.org MFH: 2019Q3 (hat: ports-secteam) Changes: head/audio/musicpd/Makefile A commit references this bug: Author: riggs Date: Wed Aug 7 16:23:05 UTC 2019 New revision: 508318 URL: https://svnweb.freebsd.org/changeset/ports/508318 Log: MFH: r508317 Enable support for logging through syslog, bump PORTREVISION PR: 239671 Submitted by: bsdpr@phoe.frmug.org Approved by: ports-secteam (riggs) Changes: _U branches/2019Q3/ branches/2019Q3/audio/musicpd/Makefile |
Created attachment 206302 [details] Patch enabling syslog support in musicpd musicpd, as is currently built by the port, rejects configurations directing it to log through syslog. A configuration line such as «log_file "syslog"» is rejected because it is regarded as a path specification. The provided patch restores the ability to log through syslog.