Bug 239738
| Summary: | factor out hardcoding of "clangXYZ" in devel/flang-clang | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mark Linimon <linimon> | ||||
| Component: | Individual Port(s) | Assignee: | Johannes M Dieterich <jmd> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | Flags: | jmd:
maintainer-feedback+
|
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 239736 | ||||||
| Attachments: |
|
||||||
LGTM A commit references this bug: Author: linimon Date: Fri Oct 4 22:13:05 UTC 2019 New revision: 513787 URL: https://svnweb.freebsd.org/changeset/ports/513787 Log: Factor out hardcoding of the string "clang<version". When doing the work to identify stale versions of clang tree-wide, these instances cause extra work. Refactor this usage into LLVM_VER. Note: this refactoring causes portlint to complain but IMHO this annoyance is worth tolerating to help ease maintainability. PR: 239737, 239738 Approved by: maintainer Changes: head/devel/flang/Makefile head/devel/flang-clang/Makefile Committed (along with 239737), thanks. |
Created attachment 206390 [details] patch to devel/flang-clang/Makefile There are a number of places in the ports tree where the string "clang<version" is called out. When doing the work to identify stale versions of clang tree-wide, these instances cause extra work. Refactor this usage into LLVM_VER. Note: this refactoring causes portlint to complain but IMHO this complication is worth tolerating to help ease maintainability. Tested on: amd64.