Bug 239787
| Summary: | java/intellij-ultimate: Update to 2019.2 | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmitry Wagin <dmitry.wagin> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Alex Dupre <ale> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | ale, andoriyu, meta | ||||||||||||
| Priority: | --- | Flags: | andoriyu:
maintainer-feedback+
|
||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Dmitry Wagin
2019-08-11 23:03:40 UTC
Created attachment 206456 [details]
intellij-ultimate.diff.gz
testport output is here: https://gist.github.com/24698cc69682e71726b01cd0f71db710 Created attachment 206677 [details]
intellij-ultimate.diff.gz
Convert to UCL pkg-message
I wrote wrong PR number in the commit message. Committed. https://svnweb.freebsd.org/changeset/ports/509486 BTW, you don't need to gz the diff. (In reply to Koichiro Iwao from comment #4) File size limit: 1000 KB (In reply to Dmitry Wagin from comment #5) I see. I'm not fully happy with this update, it brought in again a few issues of the intellij port that I already fixed in the intellij-ultimate port. I'll submit an additional patch soon. (In reply to Alex Dupre from comment #7) Please describe what kind of issues is it? I'll describe them soon. In the meantime can you tell me how did you create the pkg-plist? Both 'find -s` and 'sort' produce different ordering. (In reply to Alex Dupre from comment #9) make makeplist Created attachment 206785 [details]
Improvements
Here is my patch. Rationale:
1) drop dependency on intellij-pt4j port. That port should be removed, it includes an old pt4j version and the FreeBSD native library is already included in the upstream pty4j jar
2) install FreeBSD native library for jansi
3) fix the "Typeahead timeout is exceeded" error
4) general cleanup
As a side note, your change of the installation path is for a future removal of the CONFLICTS section or what else?
Created attachment 206788 [details]
intellij-ultimate.diff
Minor changes to better corresponding with another Jetbrains ports.
Using COPYTREE_BIN for the the *.so files makes them executable.
I don't see why we need to separate the ${RM} of a few directories and include also non-existing ones.
(In reply to Alex Dupre from comment #13) Similar with another Jetbrains ports, еру world is not limited to this port. I'm sorry, but I don't understand what you mean, what's the epy world? The same changes are very likely directly applicable to the intellij community port, if that's what you are referring to. (In reply to Alex Dupre from comment #15) epy = the devel/jetbrains-clion devel/jetbrains-goland devel/jetbrains-phpstorm devel/jetbrains-webstorm java/intellij-rubymine java/intellij-ultimate same ports I still don't get how this is addressing my comment 13, ie. that with your change the .so files would be executable and that there are separate RM lines for non-existing directories. (In reply to Alex Dupre from comment #17) The .so files are the same settings as on other library files, but it does not matter. Separate RM, because this is what differentiate it from other ports. What "non-existing directories" are we talking about? Created attachment 206790 [details]
Improvements
I suggest to replace COPYTREE_BIN with COPYTREE_SHARE to install the .so files, so that they keep the correct permissions. I'm fine to have it on a separate line in order to keep the initial COPYTREE_SHARE consistent with other ports.
Regarding the non-existing directories, since we download the tarball with -no-jbr these two lines are useless:
# Remove bundled linux JetBrains Runtime and OpenJDK
@${RM} -r ${WRKSRC}/jbr ${WRKSRC}/jre64
I've updated the patch accordingly.
Comment on attachment 206790 [details]
Improvements
I was wondering about that jbr folder since we download `no-jbr` tarball.
(In reply to Dmitry Wagin from comment #5) You can paste a link to diff somewhere else there. (In reply to Alex Dupre from comment #19) LGTM A commit references this bug: Author: ale Date: Fri Aug 23 09:08:53 UTC 2019 New revision: 509636 URL: https://svnweb.freebsd.org/changeset/ports/509636 Log: Various improvements: - remove unneeded intellij-pty4j dependency - install native library for jansi - fix the "Typeahead timeout is exceeded" error - general cleanup PR: 239787 Changes: head/java/intellij-ultimate/Makefile head/java/intellij-ultimate/files/pkg-message.in head/java/intellij-ultimate/pkg-plist |
