Bug 239857
| Summary: | lang/go14: Don't install doc and test files | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Adam Weinberger <adamw> | ||||||
| Component: | Individual Port(s) | Assignee: | Julien Laffaye <jlaffaye> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | dmgk, tobik | ||||||
| Priority: | --- | Keywords: | needs-qa | ||||||
| Version: | Latest | Flags: | tobik:
maintainer-feedback-
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Hi Julien, could you weigh in on this PR please? Maintainer timeout. Dmitri, does this look sensible to you? (In reply to Tobias Kortkamp from comment #2) That depends on whether we care about tests or not. Just removing ${WRKSRC}/test will break do-test target as there will be no tests to run. Attached patch reshuffles things a bit to only install what's needed for bootstrapping lang/go while keeping tests in working order. Tested with poudriere bulk of lang/go14 and lang/go on 113a, 120i, 120a. Created attachment 207742 [details]
go14: remove doc and test files v2
From my perspective, this looks good. Dmitri, I urge you to go make this happen! A commit references this bug: Author: dmgk Date: Tue Oct 8 00:54:59 UTC 2019 New revision: 514016 URL: https://svnweb.freebsd.org/changeset/ports/514016 Log: lang/go14: Don't install doc and test files Currently, lang/go14 installs about 1,400-ish doc and test files. The only role of go14 is to build lang/go, and those files have no role in that. PR: 239857 Approved by: jlaffaye (maintainer timeout, >1 month), tz (mentor) Differential Revision: https://reviews.freebsd.org/D21879 Changes: head/lang/go14/Makefile head/lang/go14/pkg-plist |
Created attachment 206541 [details] go14: remove doc and test files Hi Julien, Currently, lang/go14 installs about 1,400-ish doc and test files. The only role of go14 is to build lang/go, and those files have no role in that. The attached patch removes those files.