Bug 239892
| Summary: | www/tomcat9: Support Java 9+ | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Greg Lewis <glewis> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Greg Lewis <glewis> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Some People | CC: | tommyhp2, vvd | ||||||||||||
| Priority: | --- | Keywords: | feature, needs-qa | ||||||||||||
| Version: | Latest | Flags: | vvd:
maintainer-feedback+
|
||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Greg Lewis
2019-08-15 22:08:18 UTC
(In reply to Greg Lewis from comment #0) Did you forget pkg-plist diff or why did you add this line in Makefile: "JAVA_VERSION=${JAVA_PORT_VERSION}"? That was to substitute for %%JAVA_VERSION%% in the change to the rc script. It's not strictly necessary though. I could instead default the version to empty if it doesn't get determined and remove that change from the Makefile if you'd prefer. (In reply to Greg Lewis from comment #2) There are no %%JAVA_VERSION%% in files/tomcat9.in… (In reply to VVD from comment #3) Oh! Found it… (In reply to VVD from comment #4) Java version must be runtime detected, but not build time. Can you fix this in patch? Created attachment 206651 [details]
Java 9+ support in tomcat9
Plz, test this patch.
It work for me on 12.0 amd64 with openjdk8 and openjdk11.
Created attachment 206652 [details]
Java 9+ support in tomcat85
Same for tomcat85.
I found other way to check java version: > java -version 2>&1 | awk -F '"' '/version/ {print $2}' What is more correct way? > java -version 2>&1 | head -1 | sed -e 's/[^"][^"]*\"\([^\"]*\)\".*/\1/' I don't think one way is more correct than the other, they're just a different way of essentially doing the same thing. I'm ok with either. If you prefer the awk version then I have no problems with that. It is certainly shorter. Created attachment 206767 [details]
Java 9+ support in tomcat85
Replaced to awk version with full path.
Created attachment 206768 [details] Java 9+ support in tomcat9 and update to 9.0.24 Replaced to awk version with full path. Also updated to version 9.0.24: http://tomcat.apache.org/tomcat-9.0-doc/changelog.html#Tomcat_9.0.24_(markt) *** Bug 238067 has been marked as a duplicate of this bug. *** A commit references this bug: Author: glewis Date: Thu Aug 22 02:40:40 UTC 2019 New revision: 509574 URL: https://svnweb.freebsd.org/changeset/ports/509574 Log: * Update to 9.0.24 * Support Java 9+ by not setting java.endorsed.dirs for those versions PR: 239892 Submitted by: vvd@unislabs.com (maintainer) Changes: head/www/tomcat9/Makefile head/www/tomcat9/distinfo head/www/tomcat9/files/tomcat9.in A commit references this bug: Author: glewis Date: Thu Aug 22 02:46:32 UTC 2019 New revision: 509575 URL: https://svnweb.freebsd.org/changeset/ports/509575 Log: * Support Java 9+ by not setting java.endorsed.dirs for those versions PR: 239892 Submitted by: vvd@unislabs.com (maintainer) Changes: head/www/tomcat85/Makefile head/www/tomcat85/files/tomcat85.in Thanks! I've committed both final patches you provided. Thanks! |