Bug 239918
| Summary: | usbhidctl(1): include item position in report descriptor dump | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Kevin Zheng <kevinz5000> | ||||
| Component: | usb | Assignee: | Hans Petter Selasky <hselasky> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | hselasky | ||||
| Priority: | --- | ||||||
| Version: | 12.0-RELEASE | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: hselasky Date: Sat Aug 17 08:29:23 UTC 2019 New revision: 351167 URL: https://svnweb.freebsd.org/changeset/base/351167 Log: Include item position in report descriptor dump in usbhidctl(1). Submitted by: Kevin Zheng <kevinz5000@gmail.com> PR: 239918 MFC after: 1 week Changes: head/usr.bin/usbhidctl/usbhid.c A commit references this bug: Author: hselasky Date: Thu Sep 5 09:35:06 UTC 2019 New revision: 351844 URL: https://svnweb.freebsd.org/changeset/base/351844 Log: MFC r351167: Include item position in report descriptor dump in usbhidctl(1). Submitted by: Kevin Zheng <kevinz5000@gmail.com> PR: 239918 Changes: _U stable/12/ stable/12/usr.bin/usbhidctl/usbhid.c A commit references this bug: Author: hselasky Date: Thu Sep 5 09:35:41 UTC 2019 New revision: 351845 URL: https://svnweb.freebsd.org/changeset/base/351845 Log: MFC r351167: Include item position in report descriptor dump in usbhidctl(1). Submitted by: Kevin Zheng <kevinz5000@gmail.com> PR: 239918 Changes: _U stable/11/ stable/11/usr.bin/usbhidctl/usbhid.c |
Created attachment 206626 [details] Patch Include the item position (h->pos) in the report descriptor dump. This makes the output of `usbhidctl -r` more useful when many items have unassigned usages, such as when a device implements register accesses through USB HID. For example, before the patch: Input rid=0 size=8 count=1 page=Consumer usage=Unassigned, logical range 0..255 Input rid=0 size=8 count=1 page=Consumer usage=Unassigned, logical range 0..255 Both of these items look the same. After the patch: Input rid=0 pos=16 size=8 count=1 page=Consumer usage=Unassigned, logical range 0..255 Input rid=0 pos=24 size=8 count=1 page=Consumer usage=Unassigned, logical range 0..255 These are obviously different items.