Bug 239921

Summary: [NEW PORT] www/rutorrent: Web front-end for the Bittorrent client rtorrent
Product: Ports & Packages Reporter: Ivan Rozhuk <rozhuk.im>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Open ---    
Severity: Affects Only Me CC: diizzy, lwhsu, rozhuk.im
Priority: --- Keywords: feature, needs-patch, needs-qa
Version: Latest   
Hardware: Any   
OS: Any   
Description Flags
add nginx conf example, handle all config files as samples.
rozhuk.im: maintainer-approval?
rutorrent-3.10 none

Description Ivan Rozhuk 2019-08-17 04:13:35 UTC
Created attachment 206629 [details]
Comment 1 Ivan Rozhuk 2019-08-18 01:55:36 UTC
Created attachment 206650 [details]
add nginx conf example, handle all config files as samples.
Comment 2 Ivan Rozhuk 2020-02-19 16:29:53 UTC
Comment 3 Daniel Engberg freebsd_committer 2020-03-16 12:31:30 UTC
I think the general policy is not to accept new ports without a maintainer
Comment 4 Li-Wen Hsu freebsd_committer 2020-07-02 04:28:42 UTC
(In reply to rozhuk.im from comment #2)
Do you want to be the maintainer of this port?
Comment 5 Ivan Rozhuk 2020-07-02 11:58:29 UTC
(In reply to Li-Wen Hsu from comment #4)

Yes, I use it :)
Comment 6 Li-Wen Hsu freebsd_committer 2020-07-02 13:01:24 UTC
Created attachment 216139 [details]

I've done some modifications:

- Update to 3.10 (release)
- Fix include (second bsd.port.mk should be bsd.port.post.mk)
- Put submitter in MAINTAINER
- Generate patch with `make makepatch`

But it seems still have some issues:

- rutorent.conf is not in the ${FILESDIR}
- Having those permission settings is dangerous:
  @${CHMOD} -R 0777 ${STAGEDIR}${WWWDIR}/share
  @${CHMOD} 0644 ${STAGEDIR}${WWWDIR}/share/.htaccess
  Is it possible to change them? And ${CHMOD} can be replaced by `@(owner,group,mode)` in pkg-plist.

Can you check them and create a new patch based on this?
Also, please do these tests if possible:
- set `DEVELOPER=yes` in /etc/make.conf and do make again
- if possible, please test it in the poudriere.

Thanks for submitting this port!
Comment 7 Ivan Rozhuk 2020-07-02 13:16:21 UTC
(In reply to Li-Wen Hsu from comment #6)

Thanks, I will look into in next days.

> @${CHMOD} -R 0777 ${STAGEDIR}${WWWDIR}/share

must be writable for web UI process or you can not save any settings and probably some thing will not work.

> @${CHMOD} 0644 ${STAGEDIR}${WWWDIR}/share/.htaccess

but why this insecure?

> And ${CHMOD} can be replaced by `@(owner,group,mode)` in pkg-plist

This port generates pkg-plist on fly, easy to keep ${CHMOD} at "prepare" stage than patching with sed pkg-plist while it generating.
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2020-07-03 04:08:59 UTC
@Li-Wen Can you self-assign this issue since you're providing patches to it. Will reduce noise on the lists, and improve SNR.

Also: "ruTorrent is a " needs removing from COMMENT
Comment 9 Daniel Engberg freebsd_committer 2021-03-18 14:19:27 UTC
Any interest in this or can we close it?
Comment 10 Ivan Rozhuk 2021-03-18 16:14:28 UTC
I am use this, and prefer to upstream it to ports.
Comment 11 Li-Wen Hsu freebsd_committer 2021-03-18 16:30:56 UTC
(In reply to rozhuk.im from comment #10)
Happy to help, and can you help create a new patch?

For mode 0777 ${STAGEDIR}${WWWDIR}/share, I suggest we at least have a pkg-message to warn about it, or we can even tell people to change that on their own.